www.fgks.org   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library Explorer Tweaks + ?jumpTo alpha release #4617

Merged
merged 15 commits into from
Aug 9, 2021
Merged

Library Explorer Tweaks + ?jumpTo alpha release #4617

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d2c76e8
[library-explorer] Add v0 ?jumpTo url parameter
cdrini Feb 16, 2021
a7ffbfd
[library-explorer] Add v1 jumpTo
cdrini Feb 16, 2021
e806ae9
[library-explorer] Make sorting by shelf order switch to C_sort
cdrini Feb 16, 2021
9a1d6f5
[library-explorer] jumpTo now also scrolls to right position
cdrini Feb 16, 2021
0cd47b6
Fix lcc:E--* queries failing
cdrini Feb 16, 2021
c0eb1dc
[library-explorer] Fix this.$el undefined in created error
cdrini Feb 16, 2021
8932391
[library-explorer] Make default sort be random
cdrini Aug 5, 2021
ff89e1b
[library-explorer] Small perf tweaks
cdrini Aug 9, 2021
3b7737e
[library-explorer] Rm shelf visual style
cdrini Aug 9, 2021
ebcca8c
[library-explorer] Simplify Class Slider
cdrini Aug 9, 2021
73d75c7
[library-explorer] ClassSlider visual tweaks
cdrini Aug 9, 2021
3d4293d
[library-explorer] Remove some unnecessary CSS
cdrini Aug 9, 2021
be2b9ac
[library-explorer] Set css-box to be contained
cdrini Aug 9, 2021
d7f698e
[library-explorer] Fix issues with LCC jumpTo
cdrini Aug 9, 2021
12ed031
Apply suggestions from code review
cdrini Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
  • Loading branch information
@cdrini
cdrini committed Aug 9, 2021
commit 12ed0312803a02cd4f7bd8a15d93eda95e2973e3
4 changes: 3 additions & 1 deletion openlibrary/components/LibraryExplorer/components/BookRoom.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ import CONFIGS from '../configs';
/** @typedef {import('../utils.js').ClassificationNode} ClassificationNode */

/**
cdrini marked this conversation as resolved.
Show resolved Hide resolved
* Given a starting classification node, find the data needed to render the node containing
* the provided classification string.
* @param {ClassificationNode} classificationNode
* @param {string} classification (e.g. 658.91500202854)
*/
Expand All @@ -95,7 +97,7 @@ function findClassification(classificationNode, classification) {
node => testLuceneSyntax(node.query, classification));
if (!path.length) return;

// pad until length is at least 3
// pad until length is at least 3, so that we can destructure into [shelf, bookcase, room]
while (path.length < 3) path.push(null);

// Jump as deep into it as we can. I.e. the last node is the shelf, the second last the bookcase, and the 3rd last is the room.
Expand Down