www.fgks.org   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Explorer Tweaks + ?jumpTo alpha release #4617

Merged
merged 15 commits into from
Aug 9, 2021

Conversation

cdrini
Copy link
Collaborator
@cdrini cdrini commented Feb 16, 2021

Work towards #4357 #4355 . Also some miscellanious tweaks:

  • Default sort order is now random instead of most editions. This random changes every hour, so different books are show regularly.
  • Fix: When sorting in "Shelf order", only consider best classification number
    • This makes jumpTo possible
    • This also fixes a case where sorting by "Shelf order" caused a bunch of unrelated books to appear first
    • This does mean that when in shelf order, books that are shelved at multiple classification number will only appear at one
  • Fix: Searching for queries like lcc:E--*
  • ClassSlider now has 9 fewer html elements; yielding ~900 fiewer elements in the total UI
  • Small perf tweaks setting things to contain: strict where possible
  • Alpha: ?jumpTo parameter:

Technical

Testing

Screenshot

Stakeholders

@cdrini cdrini self-assigned this Jun 2, 2021
@cdrini cdrini force-pushed the feature/le-jump-to branch 3 times, most recently from e249276 to 5221fc4 Compare August 5, 2021 20:06
@cdrini cdrini changed the title Feature/le jump to Library Explorer Tweaks + ?jumpTo alpha release Aug 6, 2021
@cdrini cdrini marked this pull request as ready for review August 6, 2021 16:17
@cdrini cdrini added On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing Priority: 1 Do this week, receiving emails, time sensitive, . [managed] labels Aug 6, 2021
Currently only jumps to the correct shelf as deeply as possible. Does not e.g. scroll to the right spot. That'll be v1!
This does mean that some books (books with multiple e.g. dewey decimal numbers) might be missing, but things will no longer look wrong. Added a note as tooltip as well.
Note:
- LCC is slower for some reason; it seems to time out often
- Unsure if we want to remove all the filters if jumpTo is used; the requested value might not even be there!
The random will change every hour, so if they refresh the books will (probably) still be in the same order
Previously it had a DOM element for every label! Now it only displays one, and uses transitions to get between them. Removes ~9 DOM elements per shelf (~900 total on the page!)
Copy link
Collaborator
@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Please update comments when you get a chance.

@jimchamp jimchamp merged commit f0862af into internetarchive:master Aug 9, 2021
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants