-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library Explorer Tweaks + ?jumpTo alpha release #4617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
305a3d3
to
2ac6979
Compare
cclauss
reviewed
Feb 17, 2021
6b9e4d4
to
26fdcba
Compare
e249276
to
5221fc4
Compare
5221fc4
to
2a51e46
Compare
Currently only jumps to the correct shelf as deeply as possible. Does not e.g. scroll to the right spot. That'll be v1!
This does mean that some books (books with multiple e.g. dewey decimal numbers) might be missing, but things will no longer look wrong. Added a note as tooltip as well.
Note: - LCC is slower for some reason; it seems to time out often - Unsure if we want to remove all the filters if jumpTo is used; the requested value might not even be there!
The random will change every hour, so if they refresh the books will (probably) still be in the same order
2a51e46
to
c358eab
Compare
Previously it had a DOM element for every label! Now it only displays one, and uses transitions to get between them. Removes ~9 DOM elements per shelf (~900 total on the page!)
c358eab
to
ebcca8c
Compare
Make the sections slider full-width on mobile devices
jimchamp
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Please update comments when you get a chance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #4357 #4355 . Also some miscellanious tweaks:
lcc:E--*
contain: strict
where possiblejumpTo
positionTechnical
Testing
Screenshot
Stakeholders