Looks good. Resolving.

Change #1050438 had a related patch set uploaded (by Jayden Bailey; author: Jayden Bailey):

[mediawiki/extensions/AdvancedSearch@master] Rework AdvancedSearch's explicit namespacing to use history.pushState instead of 302 redirects

https://gerrit.wikimedia.org/r/1050438

This is already possible with the hook SpecialSearchProfiles instead of a config parameter or a MediaWiki:Sidebar-like alternative, so it should be clearer here what is really wanted (I’m aware the original author probably does not follow this task, so the question is to people interested to this task).

Mentioned in SAL (#wikimedia-operations) [2024-06-26T20:50:34Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:1049972|Enable user pages and select special pages in dark mode (1.43.0-wmf.11) (T366364 T366375 T367375 T367581 T367582 T367583)]] (duration: 08m 09s)

Mentioned in SAL (#wikimedia-operations) [2024-06-26T20:44:55Z] <jdrewniak@deploy1002> jdlrobson, jdrewniak: Backport for [[gerrit:1049972|Enable user pages and select special pages in dark mode (1.43.0-wmf.11) (T366364 T366375 T367375 T367581 T367582 T367583)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-26T20:42:24Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:1049972|Enable user pages and select special pages in dark mode (1.43.0-wmf.11) (T366364 T366375 T367375 T367581 T367582 T367583)]]

Change #1049972 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable user pages and select special pages in dark mode (1.43.0-wmf.11)

https://gerrit.wikimedia.org/r/1049972

Change #1049972 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable user pages and select special pages in dark mode (1.43.0-wmf.11)

https://gerrit.wikimedia.org/r/1049972

Fixed in https://www.mediawiki.org/wiki/Special:PermanentLink/6603711

In T367375#9924043, @Jdlrobson wrote:

❓ In Advanced search: "Sort by relevance" failed color contrast

It looks like this is in a disabled state (it has an aria-disabled). I'll clarify with @JScherer-WMF if we need a follow up ticket for this.

❓ In Advanced search: "Sort by relevance" failed color contrast

@Jdlrobson The only thing that came up was Advanced search as seen in the image below. Please let me know if this is already covered and if I can pass this or if this is an error, thanks!

This is more or less the same as T40395, I suggest closing this one as a duplicate and continue the discussion on the other one which is older.

There remains to be decided if the selection of the "default" profile is:

1. the last selected profile (as proposed in my previous comment), or
2. a profile the user has explicitely fixed in their preferences, whatever they will then navigate between different profiles during their searches.

We (Wiki Valley) were asked this feature and I just studied the (current, 1.41/1.43-alpha) behaviour. It is in fact partly already implemented but the logic is quite difficult to discover (ref: source code as of 1.43-alpha):

• when a user has used the 'advanced' profile and saved some set of namespaces, then they are sticked with the 'advanced' profile and this set of namespaces, but
• when the same user saves exactly the set of namespaces of some other profile (see below), then this other profile becomes the default displayed profile (i.e. when you enter a search in the search box, or an URL on the page Special:Search without any parameter "nsNNN" or "profile").

Change #1047187 merged by jenkins-bot:

[mediawiki/core@master] Use codex color value for interwiki header links in search

https://gerrit.wikimedia.org/r/1047187

Change #1047187 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/core@master] Use codex color value for interwiki header links in search

https://gerrit.wikimedia.org/r/1047187

In T107875#9877042, @Ladsgroup wrote:

In T107875#9861769, @TheDJ wrote:

@Ladsgroup I updated some of the searchindex patches a bit, but i got questions :)

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/935486

1. This migration approach drops the table and recreates it. There's quite a few changes in there wrt to types, engines and indexes so i guess there is something to be said for that. ata the same time..

That is actually quite messy. Once you use the abstract schema change, it takes care of it automatically, you don't need to do anything. See http://mediawiki.org/wiki/Schema%20changes on how to use that.

Change #935486 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/core@master] Searchindex primary key, InnoDB engine and title length

https://gerrit.wikimedia.org/r/935486