Temporary Disabled. :) please Go back ⚓ T320753 Make it easier to relocate a Reply Tool you've opened on mobile www.fgks.org » Address: [go: up one dir, main page] Include Form Remove Scripts Accept Cookies Show Images Show Referer Rotate13 Base64 Strip Meta Strip Title Session Cookies Page MenuHomePhabricatorSearchConfigure Global SearchLog InCreate Task Maniphest T320753 Make it easier to relocate a Reply Tool you've opened on mobileClosed, ResolvedPublicActionsEdit TaskEdit Related Tasks...Create SubtaskEdit Parent TasksEdit SubtasksMerge Duplicates InClose As DuplicateEdit Related Objects...Edit CommitsEdit MocksSubscribeMute NotificationsProtect as security issueAward TokenFlag For LaterAssigned To• EsandersAuthored ByppelbergOct 13 2022, 6:13 PM2022-10-13 18:13:39 (UTC+0)TagsDiscussionTools (Triaged)Editing-team (Kanban Board) (Ready for Sign Off)GoalMobile (Needs triage)Patch-For-ReviewMW-1.40-notes (1.40.0-wmf.27; 2023-03-13)VerifiedReferenced FilesF36927990: IMG_6A90E7CABD1A-1.jpegMar 26 2023, 5:36 AM2023-03-26 05:36:11 (UTC+0)SubscribersAklapperEAkinloose• EsandersJdlrobsonMasumrezarock100matmarexnayoubView All 9 SubscribersDescriptionIn T319148, we fixed an issue that had been causing the mobile Reply Tool to become "disassociated" from sections that contain 1 comment. In doing the above, we re-encountered a related usability issue: It can be difficult for people to relocate/return to a comment they've started drafting This task involves the work for addressing said usability issue. Story As someone who has started drafting a comment and needs to scroll the talk page to refer back to something someone said previously such that the comment I started drafting with the Reply Tool is no longer in view, I need an easy way to relocate/return to the comment I started drafting, so that I can finish expressing what I'd started with all of the context I need in mind. Requirements Meta Platform(s): Mobile Skin(s): Minerva Neue DiscussionTools state: enabled UX Prevent people from collapsing the section they have a Reply Tool open within so that they gain access to the omnipresent Return to Reply button that appears when they scroll the Reply Tool off-screen. See T319148#8308834 [i] .| Done An Approach is decided upon Requirements are documented Requirements are implemented i. Note: in implementing this approach, people would NOT be prevented from collapsing/expanding other sections.DetailsSubjectRepoBranchLines +/-Disable section toggling on mobile when replyingmediawiki/extensions/DiscussionToolsmaster+10 -0Add the ability to temporarily disable header togglingmediawiki/extensions/MobileFrontendmaster+45 -3Customize query in gerritRelated ObjectsSearch...Task GraphMentionsStatusSubtypeAssignedTask Resolved• EsandersT320753 Make it easier to relocate a Reply Tool you've opened on mobile ResolvedovasilevaT328981 [For editing team] It should be possible for other extensions to disable section collapsing on the mobile siteMentioned In T333872: Mobile reply tool doesn't expand the relevant section when recovering autosaved changesT328981: [For editing team] It should be possible for other extensions to disable section collapsing on the mobile siteT321628: Make it easier to relocate a Reply Tool (mobile) once cursor is focused within itT319148: Reply Tool (mobile) remains visible when section is collapsed Mentioned Here T328981: [For editing team] It should be possible for other extensions to disable section collapsing on the mobile siteT218414: Editing toolbar on mobile VE is not sticky (can scroll out of view) on iOST319148: Reply Tool (mobile) remains visible when section is collapsed Event Timelineppelberg created this task.Oct 13 2022, 6:13 PM2022-10-13 18:13:39 (UTC+0)Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptOct 13 2022, 6:13 PM2022-10-13 18:13:39 (UTC+0)ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.Oct 13 2022, 6:13 PM2022-10-13 18:13:47 (UTC+0)ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.ppelberg mentioned this in T319148: Reply Tool (mobile) remains visible when section is collapsed.ppelberg reassigned this task from • Esanders to nayoub.Oct 17 2022, 6:28 PM2022-10-17 18:28:23 (UTC+0)ppelberg added a project: Goal.ppelberg moved this task from Ready to Be Worked On to Design Review on the Editing-team (Kanban Board) board.ppelberg added subscribers: nayoub, • Esanders.Comment ActionsAssigning this over to @nayoub to review the approach @Esanders proposed and created this Patch Demo for: https://patchdemo.wmflabs.org/wikis/4d9ad50c24/wiki/Talk:DiscussionTools?mobileaction=toggle_view_mobilenayoub added a comment.Oct 20 2022, 10:56 PM2022-10-20 22:56:51 (UTC+0)Comment ActionsThanks, @ppelberg & @Esanders! Looks great, my only concern is that when the keyboard is opened then I'm not seeing the "Return to reply" button (since the keyboard is on top of it). I wonder if we should place the button at the top of the screen then?nayoub reassigned this task from nayoub to • Esanders.Oct 24 2022, 4:23 PM2022-10-24 16:23:01 (UTC+0)nayoub moved this task from Design Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.ppelberg added a subscriber: matmarex.Oct 25 2022, 9:55 PM2022-10-25 21:55:23 (UTC+0)Comment Actions In T320753#8334473, @nayoub wrote: Looks great, my only concern is that when the keyboard is opened then I'm not seeing the "Return to reply" button (since the keyboard is on top of it). I wonder if we should place the button at the top of the screen then? Per the conversations we had offline as a team yesterday: We are going to move forward with deploying the user experience this patch demo implements: Prevent people from collapsing the section they have a Reply Tool open within so that they gain access to the omnipresent Return to Reply button. See T319148#8308834. We are going to file a ticket for the issue @nayoub named in T320753#8334473 Note: we are NOT going to address this issue right now for two reasons: A) as @matmarex explained offline and in T218414#5027607, "affixing" the Return to reply button would open up a host of other UX issues and// B) we are assuming that people will intuitively know to tap the keyboard to return to the Reply Tool that has since disappeared from their view ppelberg updated the task description. (Show Details)Oct 25 2022, 9:55 PM2022-10-25 21:55:59 (UTC+0)ppelberg added a comment.Oct 25 2022, 9:58 PM2022-10-25 21:58:15 (UTC+0)Comment ActionsNext up: 1. @Esanders to relate the patches that were required to create this patch demo to this task 2. Editing Engineering to code review said patches ppelberg mentioned this in T321628: Make it easier to relocate a Reply Tool (mobile) once cursor is focused within it.Oct 25 2022, 10:03 PM2022-10-25 22:03:11 (UTC+0)ppelberg moved this task from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (Kanban Board) board.Aklapper added a project: Mobile.Oct 26 2022, 3:45 AM2022-10-26 03:45:18 (UTC+0)gerritbot added a comment.Nov 1 2022, 3:09 PM2022-11-01 15:09:37 (UTC+0)Comment ActionsChange 842958 had a related patch set uploaded (by Esanders; author: Esanders): [mediawiki/extensions/DiscussionTools@master] WIP Disable section toggling on mobile when replying https://gerrit.wikimedia.org/r/842958gerritbot added a project: Patch-For-Review.Nov 1 2022, 3:09 PM2022-11-01 15:09:38 (UTC+0)Comment ActionsChange 842957 had a related patch set uploaded (by Esanders; author: Esanders): [mediawiki/extensions/MobileFrontend@master] WIP Add the ability to temporarily disable header toggling https://gerrit.wikimedia.org/r/842957ppelberg edited parent tasks, added: T321961: [Config Change] Start mobile DiscussionTools A/B test; removed: T298062: [A/B Test] Run an A/B test to evaluate impact of mobile DiscussionTools.Nov 23 2022, 2:21 AM2022-11-23 02:21:22 (UTC+0)ppelberg edited parent tasks, added: T298060: [RELEASE TICKET] Offer Mobile DiscussionTools at All Wikis; removed: T321961: [Config Change] Start mobile DiscussionTools A/B test.Nov 23 2022, 4:51 PM2022-11-23 16:51:37 (UTC+0)ppelberg moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Jan 21 2023, 12:59 AM2023-01-21 00:59:48 (UTC+0)matmarex moved this task from Code Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Jan 22 2023, 6:57 PM2023-01-22 18:57:41 (UTC+0)Comment ActionsEd marked the patches as work-in-progress, I'm not sure what work is still to be done.ovasileva subscribed.Jan 31 2023, 6:40 PM2023-01-31 18:40:15 (UTC+0)Jdlrobson added a project: Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 3).Jan 31 2023, 6:44 PM2023-01-31 18:44:08 (UTC+0)Jdlrobson removed a project: Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 3).Feb 7 2023, 12:07 AM2023-02-07 00:07:22 (UTC+0)Jdlrobson subscribed.Comment ActionsI've broken out the web-team portion of this into T328981 so we can estimate it separately. Please feel free to edit the request if I've not captured it correctly.Jdlrobson mentioned this in T328981: [For editing team] It should be possible for other extensions to disable section collapsing on the mobile site.Feb 13 2023, 11:47 PM2023-02-13 23:47:49 (UTC+0)gerritbot added a comment.Feb 16 2023, 7:10 PM2023-02-16 19:10:24 (UTC+0)Comment ActionsChange 842957 had a related patch set uploaded (by Esanders; author: Esanders): [mediawiki/extensions/MobileFrontend@master] Add the ability to temporarily disable header toggling https://gerrit.wikimedia.org/r/842957gerritbot added a comment.Mar 2 2023, 5:45 PM2023-03-02 17:45:17 (UTC+0)Comment ActionsChange 842957 merged by jenkins-bot: [mediawiki/extensions/MobileFrontend@master] Add the ability to temporarily disable header toggling https://gerrit.wikimedia.org/r/842957• Esanders moved this task from Blocked / Needs More Work to Code Review on the Editing-team (Kanban Board) board.Mar 6 2023, 3:02 PM2023-03-06 15:02:21 (UTC+0)gerritbot added a comment.Mar 13 2023, 2:41 PM2023-03-13 14:41:46 (UTC+0)Comment ActionsChange 842958 merged by jenkins-bot: [mediawiki/extensions/DiscussionTools@master] Disable section toggling on mobile when replying https://gerrit.wikimedia.org/r/842958ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.27; 2023-03-13).Mar 13 2023, 3:01 PM2023-03-13 15:01:17 (UTC+0)matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Mar 13 2023, 3:15 PM2023-03-13 15:15:42 (UTC+0)matmarex added a project: Editing QA.matmarex moved this task from Inbox to High Priority on the Editing QA board.Mar 15 2023, 3:34 PM2023-03-15 15:34:51 (UTC+0)Edtadros closed subtask T328981: [For editing team] It should be possible for other extensions to disable section collapsing on the mobile site as Resolved.Mar 20 2023, 11:47 PM2023-03-20 23:47:53 (UTC+0)ppelberg removed a parent task: T298060: [RELEASE TICKET] Offer Mobile DiscussionTools at All Wikis.Mar 21 2023, 1:01 AM2023-03-21 01:01:55 (UTC+0)EAkinloose edited projects, added Verified; removed Editing QA.Mar 26 2023, 5:36 AM2023-03-26 05:36:11 (UTC+0)EAkinloose subscribed.Comment ActionsEAkinloose moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Mar 26 2023, 5:36 AM2023-03-26 05:36:23 (UTC+0)EAkinloose moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.matmarex closed this task as Resolved.Apr 3 2023, 7:13 PM2023-04-03 19:13:03 (UTC+0)matmarex updated the task description. (Show Details)matmarex mentioned this in T333872: Mobile reply tool doesn't expand the relevant section when recovering autosaved changes.Apr 3 2023, 7:15 PM2023-04-03 19:15:35 (UTC+0)Log In to Comment
In T319148, we fixed an issue that had been causing the mobile Reply Tool to become "disassociated" from sections that contain 1 comment.
In doing the above, we re-encountered a related usability issue: It can be difficult for people to relocate/return to a comment they've started drafting
This task involves the work for addressing said usability issue.
As someone who has started drafting a comment and needs to scroll the talk page to refer back to something someone said previously such that the comment I started drafting with the Reply Tool is no longer in view, I need an easy way to relocate/return to the comment I started drafting, so that I can finish expressing what I'd started with all of the context I need in mind.
Meta
UX Prevent people from collapsing the section they have a Reply Tool open within so that they gain access to the omnipresent Return to Reply button that appears when they scroll the Reply Tool off-screen. See T319148#8308834 [i] .|
i. Note: in implementing this approach, people would NOT be prevented from collapsing/expanding other sections.
Assigning this over to @nayoub to review the approach @Esanders proposed and created this Patch Demo for: https://patchdemo.wmflabs.org/wikis/4d9ad50c24/wiki/Talk:DiscussionTools?mobileaction=toggle_view_mobile
Thanks, @ppelberg & @Esanders! Looks great, my only concern is that when the keyboard is opened then I'm not seeing the "Return to reply" button (since the keyboard is on top of it). I wonder if we should place the button at the top of the screen then?
In T320753#8334473, @nayoub wrote: Looks great, my only concern is that when the keyboard is opened then I'm not seeing the "Return to reply" button (since the keyboard is on top of it). I wonder if we should place the button at the top of the screen then?
Looks great, my only concern is that when the keyboard is opened then I'm not seeing the "Return to reply" button (since the keyboard is on top of it). I wonder if we should place the button at the top of the screen then?
Per the conversations we had offline as a team yesterday:
Next up:
Change 842958 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/DiscussionTools@master] WIP Disable section toggling on mobile when replying
https://gerrit.wikimedia.org/r/842958
Change 842957 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/MobileFrontend@master] WIP Add the ability to temporarily disable header toggling
https://gerrit.wikimedia.org/r/842957
Ed marked the patches as work-in-progress, I'm not sure what work is still to be done.
I've broken out the web-team portion of this into T328981 so we can estimate it separately. Please feel free to edit the request if I've not captured it correctly.
[mediawiki/extensions/MobileFrontend@master] Add the ability to temporarily disable header toggling
Change 842957 merged by jenkins-bot:
Change 842958 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Disable section toggling on mobile when replying