Adjust the save button of the Entity Schema editor
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

The save button of the edit form of Entity Schema says "Submit", which is different from other Mediawiki text editors, which say "Publish changes" or "Save changes"
Also, the button does not have a keyboard shortcut defined, unlike the respective buttons in other forms.

Acceptance criteria:

The label of the button says "Publish changes" (publishchanges i18n message) or "Save changes" (savechanges i18n message) according to MediaWiki's EditSubmitButtonLabelPublish setting.
The button has an accesskey="s" attribute set.

Details

	Subject	Repo	Branch	Lines +/-
	Adjust the save button of the Entity Schema editor	mediawiki/extensions/EntitySchema	master	+16 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T224961 miscellaneous minor tweaks for the ShEx editor
		Resolved		Rosalie_WMDE	T230398 Adjust the save button of the Entity Schema editor

Event Timeline

WMDE-leszek created this task.Aug 13 2019, 9:39 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2019, 9:39 AM

WMDE-leszek moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.Aug 13 2019, 9:39 AM

WMDE-leszek updated the task description. (Show Details)Aug 13 2019, 12:15 PM

• alaa_wmde set the point value for this task to 3.Aug 13 2019, 12:16 PM

• alaa_wmde moved this task from Ready to estimate to Ready to pick up on the Wikidata-Campsite board.

Rosalie_WMDE subscribed.Aug 16 2019, 8:30 AM

Rosalie_WMDE moved this task from Ready to pick up to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Aug 21 2019, 7:47 AM

Rosalie_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Rosalie_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Rosalie_WMDE claimed this task.Aug 21 2019, 10:50 AM

Change 531461 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/EntitySchema@master] Adjust the save button of the Entity Schema editor

https://gerrit.wikimedia.org/r/531461

gerritbot added a project: Patch-For-Review.Aug 21 2019, 10:54 AM

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 21 2019, 2:02 PM

noarave moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 22 2019, 12:59 PM

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 26 2019, 5:21 PM

• alaa_wmde moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 27 2019, 8:37 AM

Change 531461 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Adjust the save button of the Entity Schema editor

https://gerrit.wikimedia.org/r/531461

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 27 2019, 9:00 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 27 2019, 9:10 AM

• alaa_wmde added a parent task: T224961: miscellaneous minor tweaks for the ShEx editor.Aug 27 2019, 9:29 AM