Global modules are not loaded on mobile
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tgr
	Jun 26 2016, 3:53 PM

Description

Steps to reproduce:

enable the mobilefrontend and globalcssjs roles in vagrant
create the User:Admin/global.js page on the dev wiki
log in as Admin on the mobile wiki

global.js should be loaded but is not.

Given that local user scripts/styles *are* loaded, this seems like an oversight and not one of MobileFrontend's simplifications.

Details

	Subject	Repo	Branch	Lines +/-
	Enable on 'mobile' ResourceLoader target	mediawiki/extensions/GlobalCssJs	master	+7 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Resolved	Jdlrobson	T127268 Dismantle ResourceLoader's "targets" system
Resolved	Jdlrobson	T235712 Fix the most common "Module not loadable on target mobile" warnings (Oct 2019)
Resolved	Jdlrobson	T138727 Global modules are not loaded on mobile

Event Timeline

Tgr created this task.Jun 26 2016, 3:53 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 26 2016, 3:53 PM

• jhobs added a project: Web-Team-Backlog.Jun 27 2016, 5:13 PM

Which global modules? Could you provide better replication instructions for those that do not use them?

If you are talking about gadgets... Many gadgets are very desktop specific and do not work on mobile and are thus disabled by default (MediaWiki:Mobile.js provides an alternative to MediaWiki:Common.js for example).

MobileFrontend relies on ResourceLoader targets so if something is not loaded it is because it is not using targets. I am confident it is nothing specific to MobileFrontend.

Tgr updated the task description. (Show Details)Jun 28 2016, 12:55 AM

Added reproduction steps.

Yup looks like it doesn't specify a mobile target.

Trivial to enable, but be wary of side effects - some global scripts may not be compatible with Minerva and potentially break it.

Jdlrobson removed a project: Web-Team-Backlog.Jun 29 2016, 5:15 PM

Can we enable this or add a separate global-mobile.js? I got a request to create a user's minerva.js on all wikis with Synchbot, but it feels like a step backward after all the work to migrate to global.js in the first place.

1997kB subscribed.Oct 8 2018, 3:40 AM

Jdlrobson merged a task: T232262: Add support for mobile websites global js and global css.Sep 10 2019, 2:18 PM

Jdlrobson added subscribers: Masumrezarock100, Force_Radical, DannyS712.

Schnark subscribed.Oct 28 2019, 10:21 AM

Jdlrobson added a parent task: T235712: Fix the most common "Module not loadable on target mobile" warnings (Oct 2019).Oct 31 2019, 10:19 PM

Jdlrobson mentioned this in T235712: Fix the most common "Module not loadable on target mobile" warnings (Oct 2019).Oct 31 2019, 10:31 PM

Xiplus subscribed.Jan 6 2020, 2:03 AM

Jdlrobson mentioned this in T259047: ext.globalCssJs.user and ext.globalCssJs.user.styles are silently being removed from page via targets system.Jul 28 2020, 4:15 PM

Change 616960 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/GlobalCssJs@master] Enable on 'mobile' ResourceLoader target

https://gerrit.wikimedia.org/r/616960

gerritbot added a project: Patch-For-Review.Jul 29 2020, 1:10 AM

For Tech News: Users' global.js and global.css pages will now also be loaded on the mobile site. Refer to the documentation for how to avoid applying styles to the mobile skin.