Temporary Disabled. :) please Go back ⚓ T88483 Disabled button style not right www.fgks.org » Address: [go: up one dir, main page] Include Form Remove Scripts Accept Cookies Show Images Show Referer Rotate13 Base64 Strip Meta Strip Title Session Cookies Page MenuHomePhabricatorSearchConfigure Global SearchLog InCreate Task Maniphest T88483 Disabled button style not rightClosed, ResolvedPublicActionsEdit TaskEdit Related Tasks...Create SubtaskEdit Parent TasksEdit SubtasksMerge Duplicates InClose As DuplicateEdit Related Objects...Edit CommitsEdit MocksSubscribeMute NotificationsProtect as security issueAward TokenFlag For LaterAssigned To• PrtksxnaAuthored By• violettoFeb 3 2015, 9:30 PM2015-02-03 21:30:17 (UTC+0)TagsUI-Standardization (OOUI)OOUI (OOjs-UI-0.8.0)OOUI (OOjs-UI-0.7.0)WMF-deploy-2015-02-18_(1.25wmf18)OOUI (OOjs-UI-0.8.0)Referenced FilesF40493: Screenshot_2015-02-12_13.53.57.pngFeb 12 2015, 9:55 PM2015-02-12 21:55:19 (UTC+0)F36594: Screenshot_2015-02-03_13.28.52.pngFeb 3 2015, 9:30 PM2015-02-03 21:30:17 (UTC+0)SubscribersAklapper• ElitrematmarexRicordisamoa• violettoTokens"Like" token, awarded by Elitre.Description #FFF on icon and text #DDD on button background OOjs UI mediawiki.ui (LESS) DetailsSubjectRepoBranchLines +/-MediaWiki Theme: Use white icons for disabled buttonsoojs/uimaster+6 -8mediawiki.ui: button: Use the correct background color for disabled buttonsmediawiki/coremaster+2 -2MediaWiki Theme: Fix background color for disabled buttonsoojs/uimaster+1 -1Customize query in gerritRelated ObjectsSearch...Task GraphMentionsStatusSubtypeAssignedTask Resolved• PrtksxnaT88483 Disabled button style not right ResolvedVolker_ET88038 Disabled OOjs UI button in MediaWiki theme needs more contrastMentioned In rGOJU01c87afac5d0: MediaWiki Theme: Use white icons for disabled buttonsrGOJU529ac21ee170: MediaWiki Theme: Fix background color for disabled buttonsrMW8f3d06719c91: mediawiki.ui: button: Use the correct background color for disabled buttonsT88038: Disabled OOjs UI button in MediaWiki theme needs more contrastT88449: Buttons differ between OOjs UI and mediawiki UI (tracking) Mentioned Here T88449: Buttons differ between OOjs UI and mediawiki UI (tracking) Event Timeline• violetto created this task.Feb 3 2015, 9:30 PM2015-02-03 21:30:17 (UTC+0)• violetto assigned this task to • Prtksxna.• violetto raised the priority of this task from to Needs Triage.• violetto updated the task description. (Show Details)• violetto added a project: UI-Standardization.• violetto subscribed.Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 3 2015, 9:30 PM2015-02-03 21:30:17 (UTC+0)• Prtksxna triaged this task as Medium priority.Feb 8 2015, 8:43 AM2015-02-08 08:43:59 (UTC+0)• Prtksxna set Security to None.gerritbot added a project: Patch-For-Review.Feb 11 2015, 12:54 PM2015-02-11 12:54:11 (UTC+0)gerritbot subscribed.Comment ActionsChange 189945 had a related patch set uploaded (by Prtksxna): MediaWiki Theme: Use white icons for disabled buttons https://gerrit.wikimedia.org/r/189945 Patch-For-Reviewgerritbot added a comment.Feb 11 2015, 12:54 PM2015-02-11 12:54:12 (UTC+0)Comment ActionsChange 189946 had a related patch set uploaded (by Prtksxna): MediaWiki Theme: Fix background color for disabled buttons https://gerrit.wikimedia.org/r/189946 Patch-For-Review• Prtksxna mentioned this in T88449: Buttons differ between OOjs UI and mediawiki UI (tracking).Feb 11 2015, 12:56 PM2015-02-11 12:56:39 (UTC+0)• Prtksxna mentioned this in T88038: Disabled OOjs UI button in MediaWiki theme needs more contrast.Feb 11 2015, 1:28 PM2015-02-11 13:28:16 (UTC+0)gerritbot added a comment.Feb 11 2015, 9:33 PM2015-02-11 21:33:23 (UTC+0)Comment ActionsChange 189946 merged by jenkins-bot: MediaWiki Theme: Fix background color for disabled buttons https://gerrit.wikimedia.org/r/189946Jdforrester-WMF closed this task as Resolved.Feb 11 2015, 10:40 PM2015-02-11 22:40:12 (UTC+0)Jdforrester-WMF edited projects, added OOUI, OOjs-UI-next-release; removed Patch-For-Review.Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.7.0), WMF-deploy-2015-02-18_(1.25wmf18); removed OOjs-UI-next-release.Feb 12 2015, 12:28 AM2015-02-12 00:28:16 (UTC+0)Ricordisamoa subscribed.Feb 12 2015, 8:37 AM2015-02-12 08:37:13 (UTC+0)• violetto reopened this task as Open.Feb 12 2015, 9:55 PM2015-02-12 21:55:19 (UTC+0)Comment Actions The icon on disabled buttons are still not white, reopening this task.• Prtksxna updated the task description. (Show Details)Feb 13 2015, 5:25 AM2015-02-13 05:25:59 (UTC+0)gerritbot added a project: Patch-For-Review.Feb 17 2015, 9:29 AM2015-02-17 09:29:25 (UTC+0)Comment ActionsChange 190996 had a related patch set uploaded (by Prtksxna): mediawiki.ui: button: Use the correct background color for disabled buttons https://gerrit.wikimedia.org/r/190996 Patch-For-Reviewmatmarex added a subtask: T88038: Disabled OOjs UI button in MediaWiki theme needs more contrast.Feb 17 2015, 1:58 PM2015-02-17 13:58:27 (UTC+0)gerritbot added a comment.Feb 17 2015, 2:00 PM2015-02-17 14:00:37 (UTC+0)Comment ActionsChange 190996 merged by jenkins-bot: mediawiki.ui: button: Use the correct background color for disabled buttons https://gerrit.wikimedia.org/r/190996• Prtksxna mentioned this in rMW8f3d06719c91: mediawiki.ui: button: Use the correct background color for disabled buttons.Feb 17 2015, 2:00 PM2015-02-17 14:00:51 (UTC+0)matmarex renamed this task from Disabled button color not right to Disabled button style not right.Feb 17 2015, 2:12 PM2015-02-17 14:12:46 (UTC+0)matmarex closed subtask T88038: Disabled OOjs UI button in MediaWiki theme needs more contrast as Resolved.gerritbot added a comment.Feb 17 2015, 2:25 PM2015-02-17 14:25:55 (UTC+0)Comment ActionsChange 189945 merged by jenkins-bot: MediaWiki Theme: Use white icons for disabled buttons https://gerrit.wikimedia.org/r/189945matmarex closed this task as Resolved.Feb 17 2015, 2:26 PM2015-02-17 14:26:59 (UTC+0)matmarex edited projects, added OOjs-UI-next-release; removed Patch-For-Review.matmarex removed a subscriber: gerritbot.matmarex subscribed.Comment ActionsShould be all fixed now. If you spot any inconsistencies between OOUI and mediawiki.ui, let's put them on T88449.Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.Feb 17 2015, 3:37 PM2015-02-17 15:37:48 (UTC+0)• violetto added a comment.Feb 17 2015, 10:36 PM2015-02-17 22:36:47 (UTC+0)Comment ActionsThanks, saw the fixes they look great.Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.8.0); removed OOjs-UI-next-release.Feb 19 2015, 9:35 PM2015-02-19 21:35:08 (UTC+0)• Elitre awarded a token.Feb 23 2015, 6:33 PM2015-02-23 18:33:31 (UTC+0)• Elitre subscribed.• Prtksxna mentioned this in rGOJU529ac21ee170: MediaWiki Theme: Fix background color for disabled buttons.Mar 3 2015, 7:50 PM2015-03-03 19:50:30 (UTC+0)matmarex mentioned this in rGOJU01c87afac5d0: MediaWiki Theme: Use white icons for disabled buttons.Mar 3 2015, 7:50 PM2015-03-03 19:50:42 (UTC+0)Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Mar 26 2015, 8:59 PM2015-03-26 20:59:14 (UTC+0)Danny_B moved this task from Unsorted to OOUI on the UI-Standardization board.May 20 2016, 9:00 PM2016-05-20 21:00:03 (UTC+0)matmarex reopened subtask T88038: Disabled OOjs UI button in MediaWiki theme needs more contrast as Open.May 21 2016, 7:08 AM2016-05-21 07:08:24 (UTC+0)Jdforrester-WMF closed subtask T88038: Disabled OOjs UI button in MediaWiki theme needs more contrast as Resolved.Sep 9 2016, 11:50 PM2016-09-09 23:50:07 (UTC+0)Log In to Comment
#FFF on icon and text #DDD on button background
Change 189945 had a related patch set uploaded (by Prtksxna): MediaWiki Theme: Use white icons for disabled buttons
https://gerrit.wikimedia.org/r/189945
Patch-For-Review
Change 189946 had a related patch set uploaded (by Prtksxna): MediaWiki Theme: Fix background color for disabled buttons
https://gerrit.wikimedia.org/r/189946
Change 189946 merged by jenkins-bot: MediaWiki Theme: Fix background color for disabled buttons
The icon on disabled buttons are still not white, reopening this task.
Change 190996 had a related patch set uploaded (by Prtksxna): mediawiki.ui: button: Use the correct background color for disabled buttons
https://gerrit.wikimedia.org/r/190996
Change 190996 merged by jenkins-bot: mediawiki.ui: button: Use the correct background color for disabled buttons
Change 189945 merged by jenkins-bot: MediaWiki Theme: Use white icons for disabled buttons
Should be all fixed now. If you spot any inconsistencies between OOUI and mediawiki.ui, let's put them on T88449.
Thanks, saw the fixes they look great.