www.fgks.org   »   [go: up one dir, main page]

Issue 21726 - Wrong comparison in package(...) visibilities
Summary: Wrong comparison in package(...) visibilities
Status: RESOLVED FIXED
Alias: None
Product: D
Classification: Unclassified
Component: dmd (show other issues)
Version: D2
Hardware: All All
: P1 major
Assignee: No Owner
URL:
Keywords: pull
Depends on:
Blocks:
 
Reported: 2021-03-17 16:17 UTC by Berni44
Modified: 2021-04-02 05:45 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Berni44 2021-03-17 16:17:16 UTC
Compare

```
package(std.format):

package(std) someSymbol;
```

with

```
private:

public someSymbol;
```

In second case `someSymbol` is `public`, while in first case `someSymbol` is `package(std.format)`. IMHO it should be `package(std)`.
Comment 1 Dlang Bot 2021-03-17 19:09:18 UTC
@ibuclaw created dlang/dmd pull request #12282 "fix Issue 21726 - Wrong comparison in package(...) visibilities" fixing this issue:

- fix Issue 21726 - Wrong comparison in package(...) visibilities
  
  For the purpose of creating a new scope, it makes no sense to let the
  most restrictive package attributes override any other nested visibility
  attributes.  As there is no other use of isSubsetOf(), the entire
  function has been removed.

https://github.com/dlang/dmd/pull/12282
Comment 2 Dlang Bot 2021-03-18 08:25:01 UTC
dlang/dmd pull request #12282 "fix Issue 21726 - Wrong comparison in package(...) visibilities" was merged into master:

- 35558cc21178142be008a82b8c41157e7337afb4 by Iain Buclaw:
  fix Issue 21726 - Wrong comparison in package(...) visibilities
  
  For the purpose of creating a new scope, it makes no sense to let the
  most restrictive package attributes override any other nested visibility
  attributes.  As there is no other use of isSubsetOf(), the entire
  function has been removed.

https://github.com/dlang/dmd/pull/12282
Comment 3 Dlang Bot 2021-04-02 05:45:34 UTC
dlang/dmd pull request #12339 "[dmd-cxx] Backport fixes and trivial features from upstream dmd" was merged into dmd-cxx:

- 9450325e3e411cca5fb665d5f2c14387195503aa by Iain Buclaw:
  [dmd-cxx] fix Issue 21726 - Wrong comparison in package(...) visibilities
  
  For the purpose of creating a new scope, it makes no sense to let the
  most restrictive package attributes override any other nested visibility
  attributes.  As there is no other use of isSubsetOf(), the entire
  function has been removed.

https://github.com/dlang/dmd/pull/12339