www.fgks.org   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent autostart from re-enabling practice mode after the user has explicity disabled it #221

Merged
merged 4 commits into from
Mar 13, 2022

Conversation

Lidbetter
Copy link
Contributor

No description provided.

@Lidbetter
Copy link
Contributor Author
Lidbetter commented Dec 24, 2021

#219

I may also need to update compaison checks - not sure how sourcepawn handles that (having issues with building locally to check for errors), will address if needed when I am able to build and test locally.

Is this general approach acceptable?

@Lidbetter Lidbetter changed the title prevent autostart from re-enabling practice mode after the user has explicity disabled it Prevent autostart from re-enabling practice mode after the user has explicity disabled it Dec 24, 2021
scripting/practicemode.sp Outdated Show resolved Hide resolved
@Lidbetter Lidbetter marked this pull request as ready for review December 26, 2021 23:51
@Lidbetter
Copy link
Contributor Author

I have not tested as I only have my macbook with me (no linux vm and a very slow connection)
but I think it should be close, I will compile and test when I am back at my desktop sometime in the next few days

@mrc4tt
Copy link
mrc4tt commented Dec 29, 2021

I have not tested as I only have my macbook with me (no linux vm and a very slow connection) but I think it should be close, I will compile and test when I am back at my desktop sometime in the next few days

Hi @Lidbetter.

I did test it, and it works (if I disconnect from the gameserver) - What with, if you switch map - where practicemode is still loaded (and not unloaded), so clients will not get "grenades" on change-map, but only at "reconnect". What with change-map?

@Lidbetter
Copy link
Contributor Author

This is ready for review

@Lidbetter
Copy link
Contributor Author

@splewis bumping incase you missed earler review request

@splewis splewis merged commit 2c691ec into splewis:master Mar 13, 2022
@Lidbetter Lidbetter deleted the autostart-fix branch March 14, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants