www.fgks.org   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for RSASSA-PSS algorithms (PS256, PS384, PS512) #132

Merged
merged 2 commits into from
Apr 10, 2015
Merged

Added support for RSASSA-PSS algorithms (PS256, PS384, PS512) #132

merged 2 commits into from
Apr 10, 2015

Conversation

mark-adams
Copy link
Contributor

Added support for RSASSA-PSS algorithms (PS256, PS384, PS512)

The JWT spec also mentions optional support for RSASSA-PSS using and MGF1. This is superior to PKCS #1 v1.5 (RS256, RS384, RS512) because it essentially uses a salt to randomize the padding instead of using a completely deterministic algorithm. No good attacks against PKCS #1 v1.5 padding currently exist, but PSS is recommended in new applications since it makes the signature even more random.

More info here: http://www.emc.com/emc-plus/rsa-labs/historical/raising-standard-rsa-signatures-rsa-pss.htm

Also added a test to cover our only uncovered line in jwt.api

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.29%) to 96.46% when pulling 085d28c on mark-adams:add-rsa-pss-algorithms into 2f4c770 on jpadilla:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.29%) to 96.46% when pulling 085d28c on mark-adams:add-rsa-pss-algorithms into 2f4c770 on jpadilla:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.29%) to 96.46% when pulling 085d28c on mark-adams:add-rsa-pss-algorithms into 2f4c770 on jpadilla:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.29%) to 96.46% when pulling 085d28c on mark-adams:add-rsa-pss-algorithms into 2f4c770 on jpadilla:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.76% when pulling b7bf3f5 on mark-adams:add-rsa-pss-algorithms into 2f4c770 on jpadilla:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.76% when pulling 68d1f89 on mark-adams:add-rsa-pss-algorithms into 2f4c770 on jpadilla:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.76% when pulling 68d1f89 on mark-adams:add-rsa-pss-algorithms into 2f4c770 on jpadilla:master.

@michaeldavis-wf michaeldavis-wf mentioned this pull request Apr 9, 2015
Merged
@jpadilla
Copy link
Owner
jpadilla commented Apr 9, 2015

Oh snap, this is great! As far as I know none of the other libraries do implement these.

@mark-adams
Copy link
Contributor Author

Most of the thanks goes to cryptography and OpenSSL. They did the hard parts.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.76% when pulling 77e69ff on mark-adams:add-rsa-pss-algorithms into 2f4c770 on jpadilla:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.76% when pulling 77e69ff on mark-adams:add-rsa-pss-algorithms into 2f4c770 on jpadilla:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.76% when pulling 77e69ff on mark-adams:add-rsa-pss-algorithms into 2f4c770 on jpadilla:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.76% when pulling 77e69ff on mark-adams:add-rsa-pss-algorithms into 2f4c770 on jpadilla:master.

mark-adams added a commit that referenced this pull request Apr 10, 2015
@mark-adams
Merge pull request #132 from mark-adams/add-rsa-pss-algorithms
29f1ef9 
Added support for RSASSA-PSS algorithms (PS256, PS384, PS512)
@mark-adams mark-adams merged commit 29f1ef9 into jpadilla:master Apr 10, 2015
@mark-adams mark-adams added this to the v1.1.0 milestone Apr 13, 2015
This was referenced Aug 22, 2016
Closed
Merged
This was referenced Sep 21, 2016
Closed
Closed
@vorpal-buildbot vorpal-buildbot mentioned this pull request Jun 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mark-adams @coveralls @jpadilla