www.fgks.org   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Augment non-ISBN ASIN BWB records with BookWorm data #8903

Merged
merged 11 commits into from
Apr 26, 2024
Merged

Augment non-ISBN ASIN BWB records with BookWorm data #8903

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
32645d9
Don't write non-ISBN 10 ASINs to the `isbn_10` field of a record
scottbarnes Mar 12, 2024
5f7d8d1
Allow `/isbn` to import Amazon-specific `B*` ASINS
scottbarnes Mar 13, 2024
5de7de1
Refactor `Edition.from_isbn()` to be more modular
scottbarnes Mar 16, 2024
d8162c2
Feature: supplement metadata for promise items with non-ISBN ASINs
scottbarnes Apr 11, 2024
79f4578
Feature: supplement `/api/books.json` with BookWorm data
scottbarnes Apr 11, 2024
3389233
Stop importing _init_path in manage-imports.py
scottbarnes Apr 12, 2024
115079a
Refactor: move `PrioritizedISBN` before modification
scottbarnes Apr 25, 2024
123e6e5
Feature: `?stage_import=false` to BookWorm's /isbn won't import
scottbarnes Apr 25, 2024
88e8be3
Feature: supplement B* ASIN promise items with BookWorm metadata
scottbarnes Apr 26, 2024
7cf07f5
Refactor: clarify variable names in affiliate_server.py
scottbarnes Apr 26, 2024
b3dfddd
Refactor: move b* asin import supplement logic back to load()
scottbarnes Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Next Next commit
Don't write non-ISBN 10 ASINs to the isbn_10 field of a record 
For books, Amazon usually returns ISBN 10s as its ASIN, but sometimes,
particularly in the case of ebooks, they may be numbers starting with
`B`, rather than ISBN 10s. This commit keeps the non-ISBN 10 ASIN in the
`source_records: ["amazon:asin"]` line, but prevents them from entering
the `isbn_10` field.

It also prevents `isbn_10` and `isbn_13` from having truthy `[None]`
values.
  • Loading branch information
@scottbarnes
scottbarnes committed Apr 17, 2024
commit 32645d958b2d161be1541547dd9a16bb0baef45f
7 changes: 5 additions & 2 deletions openlibrary/core/vendors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,13 +242,16 @@ def serialize(product: Any) -> dict:
logger.exception(f"serialize({product})")
publish_date = None

asin_is_isbn10 = not product.asin.startswith("B")
isbn_13 = isbn_10_to_isbn_13(product.asin) if asin_is_isbn10 else None

book = {
'url': "https://www.amazon.com/dp/{}/?tag={}".format(
product.asin, h.affiliate_id('amazon')
),
'source_records': ['amazon:%s' % product.asin],
'isbn_10': [product.asin],
'isbn_13': [isbn_10_to_isbn_13(product.asin)],
'isbn_10': [product.asin] if asin_is_isbn10 else [],
'isbn_13': [isbn_13] if isbn_13 else [],
'price': price and price.display_amount,
'price_amt': price and price.amount and int(100 * price.amount),
'title': (
Expand Down