Persist Yearly Reading Goals banner preferences #8892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
requested changes
Mar 14, 2024
There was a problem hiding this comment.
Thanks, @QuantuM410!
Just a few small changes and this will be ready to merge.
|
@jimchamp I have updated the code with the required changes, Thanks :) |
jimchamp
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8814
Technical
This PR addresses the issue where the Yearly Reading Goal banner reappears upon each login. The solution involves persisting the banner preference on the User, preventing the banner from displaying every time a user logs in.
Testing
Screenshot
Stakeholders
@jimchamp