www.fgks.org   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Sardinian strings #8856

Merged
merged 2 commits into from Mar 1, 2024
Merged

Adding Sardinian strings #8856

merged 2 commits into from Mar 1, 2024

Conversation

asereze
Copy link
Contributor
@asereze asereze commented Mar 1, 2024

Feature: it adds a Sardinian translation (name of the language in Sardinian: "Sardu", ISO 639-1 code: "sc")

Adding Sardinian (name in Sardinian: "Sardu", ISO 639-1 code: "sc")
Copy link
Collaborator
@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @asereze ! Our tests found one issue with the html, but otherwise things look good!

openlibrary/i18n/sc/messages.po Outdated Show resolved Hide resolved
@cdrini cdrini self-assigned this Mar 1, 2024
@asereze
Copy link
Contributor Author
asereze commented Mar 1, 2024

Awesome, thank you @asereze ! Our tests found one issue with the html, but otherwise things look good!

Oh, I didn't notice that. Thank you!

@cdrini cdrini merged commit 51e435e into internetarchive:master Mar 1, 2024
2 of 3 checks passed
@cdrini
Copy link
Collaborator
cdrini commented Mar 1, 2024

Thank you so much @asereze ! Sardinian users will, after our next deploy next week, automatically have the website appear in Sardinian :) I've also created a new issue for adding Sardinian to our list of languages so anyone can select the language: #8857

@scottbarnes
Copy link
Collaborator

I just wanted to chime in also to say that this is great, @asereze. Thanks so much!

@asereze
Copy link
Contributor Author
asereze commented Mar 2, 2024

@cdrini @scottbarnes You are welcome! Thank you very much to all of you for your great work!

Achorn pushed a commit to Achorn/openlibrary that referenced this pull request Mar 14, 2024
Adding Sardinian (name in Sardinian: "Sardu", ISO 639-1 code: "sc")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants