Show error messages without clearing inputs in edition edit page #8777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8802d00
to
924fa07
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8777 +/- ##
==========================================
+ Coverage 16.62% 16.65% +0.03%
==========================================
Files 88 88
Lines 4698 4706 +8
Branches 838 838
==========================================
+ Hits 781 784 +3
- Misses 3399 3404 +5
Partials 518 518 ☔ View full report in Codecov by Sentry. |
jimchamp
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Thanks @rebecca-shoptaw, and sorry for the delay! Great job on this. I think that we mislabeled the corresponding issue as a Good first issue, as the validation code isn't the easiest to work with...
Because this hasn't been reviewed in a timely manner, I'm going to commit my suggested changes and merge this. If any of my changes seem wrong to you, let me know and we can fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8423
Fix. Makes the inputs for adding contributors, classifications, identifiers, excerpts and links (on the
Editpage and theWork Detailspage) only clear once the input is accepted -- to make it easier for users to fix typos/etc. if rejected instead of having to re-type their entry.Technical
This ended up being a little more involved than expected. Since the values were automatically clearing (to be saved separately in a
datavariable) before the error checks ran, I initially implemented a workaround solution that used thedatavalues to manually re-set the input fields to their lost values after the error checks.After this, I discovered that the root of the problem was actually in the
jquery.repeat.jsfile, where all text inputs were being cleared as a side effect of storing the values indata.So I removed that line from the function, and added value clearing to each relevant function to run only after the error checks pass. I.e.
$('#select-role, #role-name').val('');This all worked great, and made the UI behave as desired -- and had the added benefit of clearing the role/identifier type as well when the entry is accepted.
Edit: Got the tests passing by adjusting the process for identifier validation specifically --
formdatanow does clear the inputs, but just for identifier entries. The inputs are re-entered via$('#id-value).val(data.value)in a couple places so that the input remains in the case of errors likeno identifier type selected.Other Technical Notes
This also involved some cleanup along the way, specifically fixing some typos in the calls to the
error()function to make sure the error message displayed and the correct input was focused on, and two quick HTML rewrites to improve the URL validation inweb.htmland make the excerpt error show/hide properly inexcerpts.html.Testing
Screenshot
Stakeholders
@jimchamp