Always show CTA banner if no reading goal exists #8606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
reviewed
Dec 13, 2023
Comment on lines
79
to
84
| $ year = current_year() | ||
| $ current_goal = get_reading_goals(year=year) | ||
| $ next_year = year + 1 | ||
| $ next_goal = get_reading_goals(year=next_year) | ||
|
|
||
| $# Is date between 1 Dec and 1 Feb? | ||
| $if not current_goal and within_date_range(12, 1, 2, 1): | ||
| $if (within_date_range(1, 1, 11, 30) and not current_goal) or (within_date_range(12, 1, 12, 31) and not next_goal): |
There was a problem hiding this comment.
$ year = current_year()
$ goal = get_reading_goals(year=year)
$if not goal:
...
rm within_date_range
|
Let's reapply on a fresh |
2683d51
to
7a45bd3
Compare
|
Noting here your observation about yearly reading goal "hide banner" cookie not working well on shared computers, @mekarpeles. |
mekarpeles
reviewed
Dec 20, 2023
| $ cookie_name = 'yrg' | ||
| $:render_template('site/banner', announcement, cookie_name, cookie_duration_days=65) | ||
| $ cookie_name = 'yrg%d' % (year % 100) | ||
| $:render_template('site/banner', announcement, cookie_name, cookie_duration_days=365) |
There was a problem hiding this comment.
Instead of 365, we should use the number of days until the end of the year.
Note: either way, this shouldn't impact site behavior because the cookie name is pinned to the year and so one year cannot bleed and effect another year.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8580
Ensures that the main My Books page always shows one of the following:
Technical
The
get_reading_goals_yearfunction has been removed, as its sole purpose was to aid in showing the banner during December.within_date_rangeand its unit tests have also been removed.Banner cookie name was changed to
yrgYY, whereYYis the last two digits of the current year. Cookie duration has been increased to one year.Important: After deployment, any patron who has hidden this banner will have to hide the banner one more time (due to the cookie change).
Testing
Screenshot
Stakeholders
@mekarpeles