Add visual feedback when updating list via My Books Droppers #8555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8555 +/- ##
==========================================
- Coverage 16.65% 16.62% -0.04%
==========================================
Files 85 85
Lines 4406 4416 +10
Branches 765 767 +2
==========================================
Hits 734 734
- Misses 3191 3199 +8
- Partials 481 483 +2 ☔ View full report in Codecov by Sentry. |
|
LGTM, tested on testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some visual feedback whenever an item is added to or removed from a list via the My Books Dropper.
If the server responds with a
4XXor5XXstatus when updating a list, a toast message is displayed and the list item's initial state (checked or unchecked) is restored.Technical
Testing
Screenshot
Loading indicator beside a list named "137"
Stakeholders
@mekarpeles