New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(author-ids) auto generate inventair links #8519
feat(author-ids) auto generate inventair links #8519
Conversation
Since this is just a link decorator, it seems like something that would be more appropriate as a browser plugin which Inventaire.io subscribers could use on any site with Wikidata links. If OpenLibrary is going to start privileging certain sites with publicity via links, I think it would be useful to have a set of public criteria which are used to determine whether or not a site qualifies. Otherwise it seems totally random when Better World Books or Inventaire.io get included and other sites don't. Here's what's in the the inventaire.io database as of their last dump: That's a tiny fraction of Wikidata. |
@tfmorris I see these no different as adding identifiers. Identifiers let us link to other parts of the internet and make our data more useful by allowing folks to use us as a 'normalizing' layer between many disparate services. We're generally not super picky ; if the link provides value we tend to include it. This specific case is interesting because we aren't storing the inventaire IDs in open library, but just linking to them. @davidscotson Does inventaire have its own set of identifiers under the hood? Or does it just use Wikidata? I'm noticing @tfmorris example seems to include another identifier space. |
Inventaire has it's own identifiers for things that are not in Wikidata. I assume they 'upgrade' to wikidata over time when possible. Not every book belongs in Wikidata since they have their own inclusion criteria:
Inventaire appear to have a wikidata passthrough, you can search for almost anything and it shows up, with some mild intelligence e.g.: https://inventaire.io/entity/wd:Q152088 detects that it's not a book or author and redirects to a subject page for "French Fries": https://inventaire.io/entity/wdt:P921-wd:Q152088 But I think that they'll show something sensible for anything that has book related data (authors, works, editions, series) in wikidata, which I assume applies to almost everything that has a wikidata link in Open Library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok then I think this seems reasonable? The only awkward bit is that this won't appear in the .json
version of the page, and won't be queriable from solr via id_inventaire:*
like our other IDs. But I reckon that's ok; it's still useful to link back and have the sameAs
acknowledgement!
Tested on testing.openlibrary.org:
- works on https://testing.openlibrary.org/authors/OL1743448A/Kaspar_von_Stieler
- no errors on books without wd id: https://testing.openlibrary.org/authors/OL6937192A/My%C5%8Fn_Kim
Closes #8518
feature
Technical
Testing
Visit an author with a wikidata ID, see the new link created belowe the wikidata link.
Screenshot
Stakeholders