Fix address bar appearing in TWA #8483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix the app id which will have `testing` in it for the future
Codecov Report
@@ Coverage Diff @@
## master #8483 +/- ##
=======================================
Coverage 15.97% 15.97%
=======================================
Files 86 86
Lines 4695 4695
Branches 822 822
=======================================
Hits 750 750
Misses 3422 3422
Partials 523 523 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @Yashs911 suggestion, this should fix the address bar in the TWA!
Unable to test unfortunately.Technical
Note I included both certs, the old and the new one, since that's what the App signing page recommended. I reckon it's to support older versions of the app.
Testing
Patch deployed this, and no more bar!!
Screenshot
Stakeholders
@Yashs911 @RayBB