www.fgks.org   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't make separate request for every publish in search/publishers #7718

Merged
merged 1 commit into from Jan 16, 2024

Conversation

cdrini
Copy link
Collaborator
@cdrini cdrini commented Mar 23, 2023

Closes #7712

Technical

  • Limit to searching for type: work ; we don't want to search editions here. This should also be a speed improvement!
  • Both the original implementation and the new implementation have slight bugs
    • Original: Would return publishers which didn't match the query. For example, searching for New York would return Springer, because a facet search finds all publishers for the query. And some books with publisher:New York also have publisher:Springer, causing it to return Springer as a match. Fixed in current by adding the facet.contains solr parameter to reduce the result set, but note this is strict, so it won't do any stemming/etc like the original search.
    • Current: The counts could be slightly off, but it's rather unlikely.
    • Current: The search is now doing a more literal substring search to appease facet.contains, but this is better than the previous approach which was returning irrelevant results.

Testing

Screenshot

Before:
image

After:
image

Stakeholders

@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Jan 15, 2024
@cdrini cdrini marked this pull request as ready for review January 15, 2024 21:34
@cdrini cdrini added Theme: Search Issues related to search UI and backend. [managed] Theme: Performance Issues related to UI or Server performance. [managed] labels Jan 15, 2024
@mekarpeles mekarpeles merged commit 56b8963 into internetarchive:master Jan 16, 2024
3 checks passed
@cdrini cdrini deleted the fix/search-publishers branch January 16, 2024 21:25
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Theme: Performance Issues related to UI or Server performance. [managed] Theme: Search Issues related to search UI and backend. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publisher search endpoint solr performance
3 participants