www.fgks.org   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new remote ID links to author pages #5364

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

jimchamp
Copy link
Collaborator
@jimchamp jimchamp commented Jun 28, 2021

Closes #5284

Adds LibriVox and Project Gutenberg links to author pages if a corresponding remote_id is present.

Technical

In addition to the /config/author.yml configurations outlined in #5093, two new identifiers must be added:

-   label: Project Gutenberg
    name: project_gutenberg
    notes: ''
    url: https://www.gutenberg.org/ebooks/author/@@@
-   label: LibriVox
    name: librivox
    notes: ''
    url: https://librivox.org/author/@@@

Testing

  1. Add the correct LibriVox and Project Gutenberg IDs to an author's identifiers.
  2. Confirm that the links are present in the "Links (outside Open Library)" section of the author page.
  3. Confirm that the links navigate to the correct Project Gutenberg and LibriVox pages.

Screenshot

remote_ids

Stakeholders

@RayBB @cdrini

@cdrini
Copy link
Collaborator
cdrini commented Jun 28, 2021

Ah sorry, got the path flipped. Should be https://openlibrary.org/config/author ; Already added :)

Copy link
Collaborator
@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Jun 28, 2021
@cdrini cdrini merged commit c682bf1 into internetarchive:master Jun 28, 2021
@jimchamp jimchamp deleted the 5284/bug/new-author-links branch September 29, 2021 20:39
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update author "Links" rendering code to use /config/author
2 participants