www.fgks.org   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI: Delete openlibrary/catalog/importer/lang.py (unused) #5321

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Fix CI: Delete openlibrary/catalog/importer/lang.py (unused) #5321

merged 1 commit into from
Jun 16, 2021

Conversation

cdrini
Copy link
Collaborator
@cdrini cdrini commented Jun 15, 2021

This makes a network request to openlibrary.org , and was causing our CI to fail during discover phase :/

Hotfix to fix CI.

Here's the output CI gave:

 ==================================== ERRORS ====================================
____________ ERROR collecting openlibrary/catalog/importer/lang.py _____________
openlibrary/catalog/importer/lang.py:14: in <module>
    languages = get_langs()
openlibrary/catalog/importer/lang.py:8: in get_langs
    lang += i
E   TypeError: 'NoneType' object is not iterable
------------------------------- Captured stdout --------------------------------
HTTPError
https://openlibrary.org/api/things?query=%7B%22type%22%3A+%22%2Ftype%2Flanguage%22%2C+%22limit%22%3A+100%2C+%22offset%22%3A+0%7D
HTTPError
https://openlibrary.org/api/things?query=%7B%22type%22%3A+%22%2Ftype%2Flanguage%22%2C+%22limit%22%3A+100%2C+%22offset%22%3A+0%7D
HTTPError
https://openlibrary.org/api/things?query=%7B%22type%22%3A+%22%2Ftype%2Flanguage%22%2C+%22limit%22%3A+100%2C+%22offset%22%3A+0%7D

Technical

Testing

Screenshot

Stakeholders

@mekarpeles @hornc

@cdrini
Delete openlibrary/catalog/importer/lang.py (unused)
bdb377d 
This makes a network request to openlibrary.org , and was causing our CI to fail during discover phase :/
@cdrini cdrini added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Jun 15, 2021
@cdrini cdrini changed the title Delete openlibrary/catalog/importer/lang.py (unused) Fix CI: Delete openlibrary/catalog/importer/lang.py (unused) Jun 15, 2021
@cdrini cdrini added Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed] and removed Priority: 1 Do this week, receiving emails, time sensitive, . [managed] labels Jun 15, 2021
@cdrini
Copy link
Collaborator Author
cdrini commented Jun 15, 2021

P0; can't merge PRs until this is through :/

@mekarpeles
Copy link
Member

lgtm -- last changed 13 years ago by @EdwardBetts

https://github.com/internetarchive/openlibrary/blame/95f1234f81c664d186e7c5413436d4ccb5b936b8/openlibrary/catalog/importer/lang.py

@mekarpeles mekarpeles merged commit a1d9f93 into internetarchive:master Jun 16, 2021
@cdrini cdrini deleted the hotfix/fix-failing-ci branch June 16, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mekarpeles mekarpeles

Labels
Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdrini @mekarpeles