Change layout of saved image modal #5288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove clearfix div from template - Add width attribute to cover image
jdlrobson
approved these changes
Jun 12, 2021
|
Jim can put on testing once our PR deploy tool is back up, ty! |
|
Sorry for the delay. Finally got round to testing. |
|
@jamesachamp this is awesome thanks for fixing! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4889
Corrects issue in which the "Finished" button overlaps links in the saved image modal.
Technical
Image div and upload information div were nested within a div having
display: flex. Removed floats from both of the nested divs. Theclearfixdiv was removed from the template. A width attribute of200was added to the image.Testing
Attempt to upload an image. Upon success, ensure that none of the modal text is overlapped by any other elements in the view.
Screenshot
Stakeholders