Remove inline JS from templates/history.html #5262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdlrobson
reviewed
Jun 2, 2021
jdlrobson
approved these changes
Jun 5, 2021
STAMATIOSL
pushed a commit
to STAMATIOSL/openlibrary
that referenced
this pull request
Jun 18, 2021
* Remove inline JS from templates/history.html and use server side equivalent
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4474
Use non JS method instead of inline JS
Technical
It basically selects two latest revision radio inputs (a10 and b11) and if only one revision is present then it selects (a1, b1)
Screenshot
Stakeholders
@jdlrobson