Fix broken graph on /admin/imports
#5666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
commented
Sep 17, 2021
| @@ -226,7 +227,7 @@ export function loadGraph(id, options = {}, tooltip_message = '', color = null) | |||
| if (tooltip_message) { | |||
| return plot_tooltip_graph($(node), data, tooltip_message, color); | |||
| } else { | |||
| return $.plot($(node), data, options); | |||
| return $.plot($(node), [{data: data}], options); | |||
There was a problem hiding this comment.
The books-added-per-day graph appears to be the only graph that reaches this else block of code. Related file:
/admin/imports/admin/imports
cdrini
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken import graph found in the admin imports dashboard.
Technical
Testing
While logged in as an admin:
Screenshot
Stakeholders
@mekarpeles