Refactor button story to use string literals #5639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18fafcf
to
3d3cea8
Compare
jdlrobson
approved these changes
Sep 9, 2021
jimchamp
reviewed
Sep 13, 2021
jimchamp
requested changes
Sep 14, 2021
There was a problem hiding this comment.
We'll also have to change the way that the buttons are instantiated. For example:
export const CtaBtn = () => ButtonTemplate('default', 'Leave waitlist');
// Other changes omitted for brevity...
export const CtaBtnWithBadge = () => ButtonTemplate('unavailable', 'Join waiting list', 4);
14be11c
to
51facfb
Compare
Co-authored-by: jimchamp <jameschamp@acm.org>
51facfb
to
d497a58
Compare
jimchamp
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor
Technical
uses string literals , as a crude way to recreate in plain html https://storybook.js.org/docs/vue/get-started/setup
Testing
Screenshot
Stakeholders
@mekarpeles @jdlrobson