Added an API for deleting work #5433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… clarifications as well
# Conflicts: # openlibrary/plugins/openlibrary/api.py
cdrini
approved these changes
Jul 30, 2021
|
Testing now... |
|
Tested by running in browser console:
Hmm, how did you test this one? I'm having trouble getting this to run for me. |
Co-authored-by: Drini Cami <cdrini@gmail.com>
Co-authored-by: Drini Cami <cdrini@gmail.com>
Co-authored-by: Drini Cami <cdrini@gmail.com>
yeah, I made the same err a couple of times too 😄 An example would be |
…n and added more type hints
cdrini
reviewed
Aug 2, 2021
cdrini
reviewed
Aug 4, 2021
cdrini
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
- Logged out
- ❔
await fetch('/works/OL54120W/-/delete', {method: 'POST'})405s instead of 403s... - ✅
await fetch('/works/OL54120W/-/delete.json', {method: 'POST'})403s!
- ❔
- Logged in, admin
- ❔
await fetch('/works/OL54120W/-/delete', {method: 'POST'})405s... - ✅
await fetch('/works/OL54120W/-/delete.json', {method: 'POST'})Works! Status: ok- ✅ Work deleted
- ✅ Editions deleted
- ✅ Single batch edit made
- ✅ await fetch('/works/OL18319A/-/delete.json', {method: 'POST'}) 405s
- ✅ await fetch('/authors/OL18319A/-/delete.json', {method: 'POST'}) 405s
- ❔
- Logged in, non-admin
- ✅
await fetch('/works/OL61982W/-/delete.json', {method: 'POST'})403s
- ✅
Ok, no clue why it's not working without .json :/ But I'll take it! Lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've proposed an idea to @cdrini that instead of deleting a work from the OL client by doing multiple http calls and getting all the editions, then making a bulk delete call to the server to delete editions of work + work. We can have an endpoint in OL server which can delete a work and all its references. This also allows us to have an option to delete work in the frontend for librarians in the future if that sounds like a good idea.
Technical
Fetches all the editions, deletes all the editions and works together. Can only be hit by admins and librarians.
Stakeholders
@cdrini