www.fgks.org   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed max-width of containers from max 960px to 1060px #4926

Merged
merged 2 commits into from
May 28, 2021

Conversation

nitahieb
Copy link
Contributor

Closes #4269

refactor max-width of containers

Technical

jamesachamp said to test change on small and large screen and it looks good for me. Tested on 16:9 ratio and 5:4.
Included screenshots of original on screen and change.

Testing

Can see changes from homepage

Screenshot

lib3
lib4
openlib
openlib2

Stakeholders

@jamesachamp

@mekarpeles
Copy link
Member

Thanks for submitting this contribution @nitahieb, tagging @jamesachamp as a reviewer :)

@mekarpeles mekarpeles added the On Staging On staging.openlibrary.org label Mar 29, 2021
@Yashs911
Copy link
Contributor
Yashs911 commented Mar 29, 2021

@nitahieb I did a quick review and the following changes are required:

  • 1. Increase max-width for footer

image

image

image

image

image

image

@nitahieb
Copy link
Contributor Author

Thank you, I'll work on this now

@nitahieb
Copy link
Contributor Author

@Yashs911
for 1 I changed max-width to 1200
2. I wasn't able to add lists to active lists to test it out, I created lists they just don't get added(prechange too)
3. I changed width to max-width(it was going off screen on phone without it) and changed it from 898 to 1138, 1200-(960-898)
4. changed the width from 70% of content area to 75%
5. changed content head from 918 to 1158
6. and I haven't been able to access the reading log page, the terminal puts out a KeyError: contact_id from openlibrary/core/civicrm.py I can post the logs but I may try to just reset the files.

I'd really appreciate help on 2 and 6 and general feedback

@cdrini
Copy link
Collaborator
cdrini commented Mar 30, 2021

Thank you @nitahieb ! For (4), can you try removing the float:lefts, and setting .workDetails to be display: flex? Then move .workFooter out of .workDetails. Something sort of like:

/* page-book.css | http://staging.openlibrary.org/static/build/page-book.css?v=0b126c04d6828cc4e586489bf39de629 */

@media only screen and (min-width: 960px) {
  div.editionAbout {
    /* float: left; */
    /* width: 70%; */
    flex: 1;
  }
  div.editionCover {
    /* float: left; */
  }
}

#test-body-mobile {
  /* max-width: 1200px; */
  max-width: 1060px;
}

.header-bar {
  /* max-width: 1200px; */
  max-width: 1060px;
}

.workDetails {
  display: flex;
}

.workFooter {
  /* clear: both; */
}

Note we'll likely want to tweak the 1200px, so try to avoid having too many magic values based on it (like "75% of content area").

1200px is looking a touch too wide for me right now; can you try it at 1060px? That should also make a lot of the UI problems disappear as well.

@Yashs911
Copy link
Contributor

@nitahieb
For 2. one way is to make 3-4 lists locally and add around 7-8 books, and after some time, you will be able to see the active lists.
For 6. Can you share the ss of the error

@nitahieb
Copy link
Contributor Author
nitahieb commented Mar 31, 2021

@cdrini I'll try that now, thank you! and I'll try to change all the max-values to be based on 1060px, I used 1200px because #4269
Just to confirm, to get workFooter out of WorkDetails I'll need to change the HTML?

@nitahieb
Copy link
Contributor Author

@Yashs911 thank you the lists thing worked

By ss do you mean screenshot?
image
image

@cdrini
Copy link
Collaborator
cdrini commented Mar 31, 2021

@nitahieb Yes exactly :) Hopefully that won't be too messy. We might change the width again as we play around with it, cause opinions always change once you start using something :)

adjusted width of lists to take  up 30% and be centered
changed graph width to max_width and changed from 898px to 998px
changed container on books size to take up 75% instead of 70%
changed contenthead max-width to 1018
@nitahieb
Copy link
Contributor Author

I did all the other changes except for 4 and 6, for 2 i changed the list entry width from 280px to 30% of container, I don't know what others think about that. I also thought it would be good to centre the entries.

@Yashs911
Copy link
Contributor
Yashs911 commented Apr 1, 2021

@nitahieb Great! I have updated my initial comment and the only thing that needs to be fixed now is [3] and [4].

@cdrini cdrini added On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing and removed On Staging On staging.openlibrary.org labels May 4, 2021
@cdrini cdrini assigned cdrini and unassigned jimchamp May 28, 2021
Copy link
Collaborator
@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been on testing for a while and working well! Merging 🚀 Any other refactors/fixes can be done in future PRs.

@cdrini cdrini merged commit 3d4e43e into internetarchive:master May 28, 2021
@cdrini
Copy link
Collaborator
cdrini commented May 28, 2021

@nitahieb would you be able to open a PR to fix the author's page? That one looks a little lopsided :) https://testing.openlibrary.org/authors/OL24522A/Jonathan_Swift

image

@cdrini cdrini changed the title changed max-width of containers from max 960px to 1200px changed max-width of containers from max 960px to 1060px Jun 29, 2021
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase max-width of the containers
5 participants