-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed max-width of containers from max 960px to 1060px #4926
Conversation
Thanks for submitting this contribution @nitahieb, tagging @jamesachamp as a reviewer :) |
@nitahieb I did a quick review and the following changes are required:
|
Thank you, I'll work on this now |
@Yashs911 I'd really appreciate help on 2 and 6 and general feedback |
Thank you @nitahieb ! For (4), can you try removing the /* page-book.css | http://staging.openlibrary.org/static/build/page-book.css?v=0b126c04d6828cc4e586489bf39de629 */
@media only screen and (min-width: 960px) {
div.editionAbout {
/* float: left; */
/* width: 70%; */
flex: 1;
}
div.editionCover {
/* float: left; */
}
}
#test-body-mobile {
/* max-width: 1200px; */
max-width: 1060px;
}
.header-bar {
/* max-width: 1200px; */
max-width: 1060px;
}
.workDetails {
display: flex;
}
.workFooter {
/* clear: both; */
} Note we'll likely want to tweak the 1200px, so try to avoid having too many magic values based on it (like "75% of content area"). 1200px is looking a touch too wide for me right now; can you try it at 1060px? That should also make a lot of the UI problems disappear as well. |
@nitahieb |
@Yashs911 thank you the lists thing worked |
@nitahieb Yes exactly :) Hopefully that won't be too messy. We might change the width again as we play around with it, cause opinions always change once you start using something :) |
adjusted width of lists to take up 30% and be centered changed graph width to max_width and changed from 898px to 998px changed container on books size to take up 75% instead of 70% changed contenthead max-width to 1018
I did all the other changes except for 4 and 6, for 2 i changed the list entry width from 280px to 30% of container, I don't know what others think about that. I also thought it would be good to centre the entries. |
@nitahieb Great! I have updated my initial comment and the only thing that needs to be fixed now is [3] and [4].
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been on testing for a while and working well! Merging 🚀 Any other refactors/fixes can be done in future PRs.
@nitahieb would you be able to open a PR to fix the author's page? That one looks a little lopsided :) https://testing.openlibrary.org/authors/OL24522A/Jonathan_Swift |
Closes #4269
refactor max-width of containers
Technical
jamesachamp said to test change on small and large screen and it looks good for me. Tested on 16:9 ratio and 5:4.
Included screenshots of original on screen and change.
Testing
Can see changes from homepage
Screenshot
Stakeholders
@jamesachamp