-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Half Star Rating #4401
Merged
Merged
Add Half Star Rating #4401
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3337ec6
fix
Yashs911 aeed01a
svg icons
Yashs911 5554fe8
mobile fix
Yashs911 a3686a6
Added percentage based star ratings
Yashs911 d9f0327
Removed css variables
Yashs911 8a3b1a8
Lint Fix
Yashs911 0244f54
Added Half Star using CSS
Yashs911 8c45b39
lint fix
Yashs911 dffb3e8
Increase bundlesize of page-edit.css
Yashs911 4227cad
refactoring
Yashs911 8a60687
Update bundlesize.config.json
jdlrobson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ | |
} | ||
} | ||
&__star { | ||
float: left; | ||
color: @orange; | ||
font-size: 1.3em; | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why
rating_stats['avg_rating']
here and notrating_stats.get('avg_rating')
(or using a cached variable as above) ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used
$avg