Clean/reorg /dev subnav + add i18n (#5363)

internetarchive · Jul 7, 2021 · b4f6869 · b4f6869 · odavido55 · Jul 15, 2021
1 parent aa194cb
commit b4f6869
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 22 deletions.
diff --git a/openlibrary/macros/Subnavigation.html b/openlibrary/macros/Subnavigation.html
@@ -1,32 +1,28 @@
 $def with (page)
 
-$ dev_nav1 = [
-$     ("/developers", "Developers"),
-$     ("/developers/api", "API"),
-$     ("/data", "Data"),
-$     ("/developers/licensing", "Licensing"),
-$ ]
-
-$ dev_nav2 = [
-$   ("http://github.com/internetarchive/openlibrary/issues", "Bugs"),
-$   ("http://github.com/internetarchive/openlibrary", "Source Code"),
-$   ("http://code.openlibrary.org/", "OL Development"),
+$ dev_pages = ["/developers", "/data", "/developers/api", "/developers/licensing"]
+$ dev_nav = [
+$     ("/developers", _("Developer Center (Home)")),
+$     ("/developers/api", _("Web API")),
+$     ("https://github.com/internetarchive/openlibrary-client", _("Client Library")),
+$     ("/data", _("Data Dumps")),
+$     ("https://github.com/internetarchive/openlibrary", _("Source Code")),
+$     ("https://github.com/internetarchive/openlibrary/issues", _("Report an Issue")),
+$     ("/developers/licensing", _("Licensing")),
 $ ]
 
 $ tour_nav = [
-$     ("/tour", "Welcome"),
-$     ("/search/howto", "Searching Open Library"),
-$     ("/tour/reading", "Reading Books"),
-$     ("/tour/books", "Adding & Editing Books"),
-$     ("/tour/subjects", "Using Subjects"),
-$     ("/help/faq", "Open Library F.A.Q."),
+$     ("/tour", _("Welcome")),
+$     ("/search/howto", _("Searching Open Library")),
+$     ("/tour/reading", _("Reading Books")),
+$     ("/tour/books", _("Adding & Editing Books")),
+$     ("/tour/subjects", _("Using Subjects")),
+$     ("/help/faq", _("Open Library F.A.Q.")),
 $ ]
 
-$if page.key in ["/developers","/data","/developers/api","/developers/licensing","/developers/ol","/developers/docs"]:
+$if page.key in dev_pages:
     <div class="subNav sansserif">
-        $:render_template("lib/subnavigation", dev_nav1)
-        <span style="float: left; padding: 0px 10px">&bull;</span>
-        $:render_template("lib/subnavigation", dev_nav2)
+        $:render_template("lib/subnavigation", dev_nav)
     </div>
     <br style="clear: both;"/>
 

diff --git a/openlibrary/templates/lib/nav_foot.html b/openlibrary/templates/lib/nav_foot.html
@@ -30,7 +30,7 @@ <h2>$:_('Discover')</h2>
       <div>
         <h2>$:_('Develop')</h2>
         <ul>
-          <li><a href="/developers" title="$_('Explore Open Library Development Center')">$_('Development Center')</a></li>
+          <li><a href="/developers" title="$_('Explore Open Library Developer Center')">$_('Developer Center')</a></li>
           <li><a href="/developers/api" title="$_('Explore Open Library APIs')">$_('API Documentation')</a></li>
           <li><a href="/developers/dumps" title="$_('Bulk Open Library data')">$_('Bulk Data Dumps')</a></li>
           <li><a href="https://github.com/internetarchive/openlibrary/wiki/Writing-Bots" title="$_('Write a bot')">$_('Writing Bots')</a></li>