www.fgks.org   »   [go: up one dir, main page]

Skip to content

Commit

Permalink
Get rid of unused parameters from AbsoluteCaretBoundsOf()
Browse files Browse the repository at this point in the history
This patch gets rid of unused parameters from
|AbsoluteCaretBoundsOf()| for improving code health.

Change-Id: I8bb6b2d302c878dfc64cfcc931085a67b21f2893
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3267819
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940670}
  • Loading branch information
yosinch authored and Chromium LUCI CQ committed Nov 11, 2021
1 parent a3bc9b4 commit 87fce26
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
5 changes: 2 additions & 3 deletions third_party/blink/renderer/core/editing/local_caret_rect.cc
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,9 @@ IntRect AbsoluteSelectionBoundsOf(const VisiblePosition& visible_position) {
return AbsoluteSelectionBoundsOfAlgorithm<EditingStrategy>(visible_position);
}

IntRect AbsoluteCaretBoundsOf(const PositionInFlatTreeWithAffinity& position,
EditingBoundaryCrossingRule rule) {
IntRect AbsoluteCaretBoundsOf(const PositionInFlatTreeWithAffinity& position) {
return AbsoluteCaretBoundsOfAlgorithm<EditingInFlatTreeStrategy>(
position, nullptr, rule);
position, nullptr, kCanCrossEditingBoundary);
}

} // namespace blink
5 changes: 2 additions & 3 deletions third_party/blink/renderer/core/editing/local_caret_rect.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,8 @@ CORE_EXPORT IntRect AbsoluteCaretBoundsOf(
const PositionWithAffinity&,
LayoutUnit* extra_width_to_end_of_line = nullptr,
EditingBoundaryCrossingRule rule = kCanCrossEditingBoundary);
CORE_EXPORT IntRect AbsoluteCaretBoundsOf(
const PositionInFlatTreeWithAffinity&,
EditingBoundaryCrossingRule rule = kCanCrossEditingBoundary);
CORE_EXPORT IntRect
AbsoluteCaretBoundsOf(const PositionInFlatTreeWithAffinity&);

CORE_EXPORT IntRect AbsoluteSelectionBoundsOf(const VisiblePosition&);

Expand Down

0 comments on commit 87fce26

Please sign in to comment.