www.fgks.org   »   [go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T343979

IP address warning on Lexeme editing page
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

As an anonymous editor I want to be warned that my IP address will be used in edit histories when I am making edits to a Lexeme, Form or Sense.

Problem:
We currently don't show the "IP address warning" message when a Lexeme, Form or Sense is edited like we do when an Item is edited.

We need to have the same pop-up message appear when a Lexeme, Form or Sense is edited to notify the users that their IP address will be included in the edit history.

Screenshot

image.png (196×319 px, 19 KB)

Screenshot from an Item page when not logged in and an edit is being made

Copy
Warning: You are not logged in. Your IP address will be publicly visible if you make any edits. If you log in or create an account, your edits will be attributed to a username, among other benefits.

BDD
GIVEN a Lexeme
AND an editor that is not logged in
WHEN a Lexeme, Form or Sense is edited
THEN the IP address warning message is displayed

Acceptance criteria:

  • "IP address warning" is displayed when an edit of a Lexeme, Form or Sense is made by an anonymous user

Details

SubjectRepoBranchLines +/-
Show a warning when editing the lexeme "header" as anonymousmediawiki/extensions/WikibaseLexememaster+17 -5
Show a warning when editing forms and sense as anonymousmediawiki/extensions/WikibaseLexememaster+9 -2
Customize query in gerrit

Related Objects

Event Timeline

Arian_Bozorg created this task.Aug 10 2023, 1:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2023, 1:22 PM
Arian_Bozorg added projects: Wikidata, Wikidata Lexicographical data.Aug 10 2023, 1:22 PM
Arian_Bozorg updated the task description. (Show Details)
Arian_Bozorg renamed this task from IP address warning on Lexeme editing page to [SW] IP address warning on Lexeme editing page .Aug 11 2023, 9:15 AM
Michael subscribed.Aug 14 2023, 11:30 AM
karapayneWMDE moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.Aug 15 2023, 2:07 PM
Arian_Bozorg renamed this task from [SW] IP address warning on Lexeme editing page to IP address warning on Lexeme editing page .Aug 16 2023, 9:02 AM
Arian_Bozorg updated the task description. (Show Details)
karapayneWMDE moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Aug 16 2023, 9:37 AM
WMDE-leszek set the point value for this task to 8.Aug 22 2023, 9:28 AM
WMDE-leszek moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.
WMDE-leszek edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
ItamarWMDE subscribed.EditedAug 23 2023, 10:08 AM

Task breakdown notes:

  • A good place to start looking into this is: attachAnonymousEditWarningTrigger in repo/resources/wikibase.ui.entityViewInit.js
  • This is probably not parallellizable.
ItamarWMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Aug 23 2023, 10:09 AM
ItamarWMDE mentioned this in T330550: Anonymous editor warning login link doesn't include returnto parameter.Aug 23 2023, 10:25 AM
hoo claimed this task.Sep 5 2023, 1:26 PM
hoo moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.
gerritbot added a comment.Sep 12 2023, 7:19 PM

Change 956943 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/WikibaseLexeme@master] Show a warning when editing forms and sense as anonymous

https://gerrit.wikimedia.org/r/956943

gerritbot added a project: Patch-For-Review.Sep 12 2023, 7:19 PM
hoo moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Sep 12 2023, 7:20 PM
gerritbot added a comment.Sep 13 2023, 1:55 PM

Change 957299 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/WikibaseLexeme@master] Show a warning when editing the lexeme "header" as anonymous

https://gerrit.wikimedia.org/r/957299

gerritbot added a comment.Sep 14 2023, 2:19 PM

Change 956943 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Show a warning when editing forms and sense as anonymous

https://gerrit.wikimedia.org/r/956943

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Sep 14 2023, 4:00 PM
gerritbot added a comment.Sep 15 2023, 9:32 AM

Change 957299 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Show a warning when editing the lexeme "header" as anonymous

https://gerrit.wikimedia.org/r/957299

Maintenance_bot removed a project: Patch-For-Review.Sep 15 2023, 10:10 AM
hoo moved this task from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board.Sep 15 2023, 10:17 AM
Arian_Bozorg closed this task as Resolved.Sep 25 2023, 12:57 PM
Arian_Bozorg moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.

This looks good to me :) thanks so much

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits