Temporary Disabled. :) please Go back ⚓ T319230 [QA task] comparison testing for Special: Search www.fgks.org » Address: [go: up one dir, main page] Include Form Remove Scripts Accept Cookies Show Images Show Referer Rotate13 Base64 Strip Meta Strip Title Session Cookies Page MenuHomePhabricatorSearchConfigure Global SearchLog InCreate Task Maniphest T319230 [QA task] comparison testing for Special: SearchClosed, ResolvedPublicActionsEdit TaskEdit Related Tasks...Create SubtaskEdit Parent TasksEdit SubtasksMerge Duplicates InClose As DuplicateEdit Related Objects...Edit CommitsEdit MocksSubscribeMute NotificationsProtect as security issueAward TokenFlag For LaterAssigned TomatthiasmullieAuthored ByEtonkovidovaOct 3 2022, 6:20 PM2022-10-03 18:20:09 (UTC+0)TagsStructured-Data-Backlog (Current Work) (Code Review)SDAW-Search-Improvements (Backlog)MW-1.40-notes (1.40.0-wmf.6; 2022-10-17)User-notice-archive (Backlog)Referenced FilesF35606286: Screen Shot 2022-10-20 at 3.20.17 PM.pngOct 20 2022, 10:26 PM2022-10-20 22:26:50 (UTC+0)F35605995: Screen Shot 2022-10-20 at 1.19.45 PM.pngOct 20 2022, 10:26 PM2022-10-20 22:26:50 (UTC+0)F35546096: Screenshot 2022-10-04 at 10.04.28.pngOct 4 2022, 8:08 AM2022-10-04 08:08:46 (UTC+0)F35546069: Screen Shot 2022-10-04 at 9.38.17 AM.pngOct 4 2022, 7:48 AM2022-10-04 07:48:36 (UTC+0)F35546067: Screen Shot 2022-10-04 at 9.40.47 AM.pngOct 4 2022, 7:48 AM2022-10-04 07:48:36 (UTC+0)F35546065: Screen Shot 2022-10-03 at 8.10.52 PM.pngOct 4 2022, 7:48 AM2022-10-04 07:48:36 (UTC+0)F35545478: Screen Shot 2022-10-03 at 8.05.03 PM.pngOct 3 2022, 6:20 PM2022-10-03 18:20:09 (UTC+0)F35545475: Screen Shot 2022-10-03 at 7.24.57 PM.pngOct 3 2022, 6:20 PM2022-10-03 18:20:09 (UTC+0)View All 13 FilesSubscribersAklapperEtonkovidovamatthiasmullieSnehaDescription(1) When audio/video and other media (pdf, djvu) are returned in Search, the thumbnails are vertically centered instead of being aligned at the top of the row. enwiki betalabscurrent production wmf.3 audio files video files non-media files CORRECT img files (2) Two small images (img_size <100) display a blank placeholder. Images with img_size >300are displayed correctly. enwiki betalabsproduction wmf.3 An example from enwiki betalabs when the returned results are mixed types of files: (3) Placeholder grows along with the height of the search result's table if content ends up being larger: DetailsSubjectRepoBranchLines +/-Search thumbnails visual tweaksmediawiki/coremaster+3 -3Customize query in gerritRelated ObjectsMentionsDuplicatesMentioned In T306883: [L] Searchers see thumbnails next to search results on the special:search page Mentioned Here T306883: [L] Searchers see thumbnails next to search results on the special:search pageT321362: [wmf.6 - regression] Mobile: non-media files thumbnails displayed incorrectly Duplicates Merged Here T320550: The placeholder image does not retain the square size when the search result gets taller Event TimelineEtonkovidova created this task.Oct 3 2022, 6:20 PM2022-10-03 18:20:09 (UTC+0)Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2022, 6:20 PM2022-10-03 18:20:09 (UTC+0)Etonkovidova moved this task from Incoming to Needs QA on the Structured-Data-Backlog (Current Work) board.Oct 3 2022, 6:20 PM2022-10-03 18:20:26 (UTC+0)Etonkovidova mentioned this in T306883: [L] Searchers see thumbnails next to search results on the special:search page.Oct 3 2022, 6:25 PM2022-10-03 18:25:46 (UTC+0)Etonkovidova updated the task description. (Show Details)Oct 4 2022, 6:00 AM2022-10-04 06:00:57 (UTC+0)Etonkovidova renamed this task from [QA task] check Special search on mobile to [QA task] comparison testsing for Special: Search.Oct 4 2022, 7:48 AM2022-10-04 07:48:36 (UTC+0)Etonkovidova updated the task description. (Show Details)Etonkovidova updated the task description. (Show Details)Etonkovidova added subscribers: matthiasmullie, Sneha.matthiasmullie updated the task description. (Show Details)Oct 4 2022, 8:08 AM2022-10-04 08:08:46 (UTC+0)gerritbot added a comment.Oct 4 2022, 8:11 AM2022-10-04 08:11:39 (UTC+0)Comment ActionsChange 838071 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie): [mediawiki/core@master] Search thumbnails visual tweaks https://gerrit.wikimedia.org/r/838071gerritbot added a project: Patch-For-Review.Oct 4 2022, 8:11 AM2022-10-04 08:11:40 (UTC+0)matthiasmullie claimed this task.Oct 4 2022, 8:12 AM2022-10-04 08:12:09 (UTC+0)matthiasmullie moved this task from Needs QA to Code Review on the Structured-Data-Backlog (Current Work) board.Comment Actions#2 is unrelated to this work; looks like that image is simply corrupt: https://en.wikipedia.beta.wmflabs.org/wiki/File:SVG_XSS4.svg I also added a #3. Have a patch in CR to fix #1 & #3.matthiasmullie merged a task: T320550: The placeholder image does not retain the square size when the search result gets taller.Oct 12 2022, 6:48 AM2022-10-12 06:48:37 (UTC+0)CBogen added a project: SDAW-Search-Improvements.Oct 12 2022, 1:07 PM2022-10-12 13:07:53 (UTC+0)gerritbot added a comment.Oct 17 2022, 9:18 AM2022-10-17 09:18:41 (UTC+0)Comment ActionsChange 838071 merged by jenkins-bot: [mediawiki/core@master] Search thumbnails visual tweaks https://gerrit.wikimedia.org/r/838071Maintenance_bot removed a project: Patch-For-Review.Oct 17 2022, 9:31 AM2022-10-17 09:31:29 (UTC+0)ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 17 2022, 10:00 AM2022-10-17 10:00:52 (UTC+0)Quiddity renamed this task from [QA task] comparison testsing for Special: Search to [QA task] comparison testing for Special: Search.Oct 20 2022, 8:39 PM2022-10-20 20:39:22 (UTC+0)Quiddity added a project: User-notice.Quiddity moved this task from To Triage to In current Tech/News draft on the User-notice board.Etonkovidova closed this task as Resolved.Oct 20 2022, 10:26 PM2022-10-20 22:26:50 (UTC+0)Comment ActionsRe-checked in enwiki wmf.6: In T319230#8282076, @matthiasmullie wrote: #2 is unrelated to this work; looks like that image is simply corrupt: https://en.wikipedia.beta.wmflabs.org/wiki/File:SVG_XSS4.svg I also added a #3. Have a patch in CR to fix #1 & #3. Thx, @matthiasmullie ! #1 & #3 look good in wmf.6. However, it seems that #1 has sort of regression in displaying the thumbnails for non-media files on mobile - filed as T321362 wmf.3wmf.6 For (2) I checked enwiki - the files which size<100 will be displayed as a blank squares - https://en.wikipedia.org/w/index.php?fulltext=1&profile=default&search=File%3Adeletion+error+enwp&title=Special%3ASearch&ns0=1 However, there are only few files of such small size and displaying them as a blank squares is somewhat better than before: wmf.3wmf.6 Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Oct 27 2022, 10:52 PM2022-10-27 22:52:23 (UTC+0)Maintenance_bot edited projects, added User-notice-archive; removed User-notice.Nov 6 2022, 11:30 PM2022-11-06 23:30:29 (UTC+0)Sneha added a comment.Edited · Nov 7 2022, 3:04 PM2022-11-07 15:04:50 (UTC+0)Comment Actions@matthiasmullie are the file thumbnails going to be square too? I thought we will keep them as is because it helps with, perhaps, highlighting the difference in interactions with thumbnails on article vs files. For files it would be good to see the entire image since thats's what the user searched for.matthiasmullie added a comment.Nov 14 2022, 12:11 PM2022-11-14 12:11:58 (UTC+0)Comment ActionsRight now, file thumbnails are indeed also square. There were a couple of thumbnail changes that kind of necessitated changing those as well (e.g. they became smaller & whitespace changed a bit) Since there was no explicit indication of how to adjust file thumbnails in response, I assumed we'd be making the same changes there (see T306883#8202831 for more context) We can go back and change file thumbnails if we wanted to; e.g. containing them within the bounding box like they used to, instead of filling. That said, I don't think that would be particularly useful WRT "highlighting the difference", since a square-ish file thumbnail would still look like a square article thumbnail. Can you create a new ticket with details for what we want file thumbnails to look like?Sneha added a comment.Nov 21 2022, 6:46 PM2022-11-21 18:46:42 (UTC+0)Comment Actionsokay thanks for the background. Based on what you said, we can leave file thumbnails as they are for now. This is only my assumption that it may cause some interaction confusion but it may not as user's may have different expectations of what they do based on the type of results. If we hear any concerns we can re-evaluate.Log In to Comment
(1) When audio/video and other media (pdf, djvu) are returned in Search, the thumbnails are vertically centered instead of being aligned at the top of the row.
(2) Two small images (img_size <100) display a blank placeholder. Images with img_size >300are displayed correctly.
An example from enwiki betalabs when the returned results are mixed types of files:
(3) Placeholder grows along with the height of the search result's table if content ends up being larger:
Change 838071 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):
[mediawiki/core@master] Search thumbnails visual tweaks
https://gerrit.wikimedia.org/r/838071
#2 is unrelated to this work; looks like that image is simply corrupt: https://en.wikipedia.beta.wmflabs.org/wiki/File:SVG_XSS4.svg
I also added a #3. Have a patch in CR to fix #1 & #3.
Change 838071 merged by jenkins-bot:
Re-checked in enwiki wmf.6:
In T319230#8282076, @matthiasmullie wrote: #2 is unrelated to this work; looks like that image is simply corrupt: https://en.wikipedia.beta.wmflabs.org/wiki/File:SVG_XSS4.svg I also added a #3. Have a patch in CR to fix #1 & #3.
Thx, @matthiasmullie ! #1 & #3 look good in wmf.6. However, it seems that #1 has sort of regression in displaying the thumbnails for non-media files on mobile - filed as T321362
For (2) I checked enwiki - the files which size<100 will be displayed as a blank squares - https://en.wikipedia.org/w/index.php?fulltext=1&profile=default&search=File%3Adeletion+error+enwp&title=Special%3ASearch&ns0=1
However, there are only few files of such small size and displaying them as a blank squares is somewhat better than before:
@matthiasmullie are the file thumbnails going to be square too? I thought we will keep them as is because it helps with, perhaps, highlighting the difference in interactions with thumbnails on article vs files. For files it would be good to see the entire image since thats's what the user searched for.
Right now, file thumbnails are indeed also square.
There were a couple of thumbnail changes that kind of necessitated changing those as well (e.g. they became smaller & whitespace changed a bit) Since there was no explicit indication of how to adjust file thumbnails in response, I assumed we'd be making the same changes there (see T306883#8202831 for more context)
We can go back and change file thumbnails if we wanted to; e.g. containing them within the bounding box like they used to, instead of filling. That said, I don't think that would be particularly useful WRT "highlighting the difference", since a square-ish file thumbnail would still look like a square article thumbnail.
Can you create a new ticket with details for what we want file thumbnails to look like?
okay thanks for the background. Based on what you said, we can leave file thumbnails as they are for now. This is only my assumption that it may cause some interaction confusion but it may not as user's may have different expectations of what they do based on the type of results. If we hear any concerns we can re-evaluate.