Expandable cross-wiki bundle notification count does not get updated after some messages were marked as read
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Etonkovidova
	May 13 2016, 11:53 PM

Description

Found in production.
The screen recording shows how to make two counters - the badge count and the bundle counter - different. Below are detailed instrictions.

bundle_count_incorrect.mov4 MBDownload

Have, for example, three foreign wiki notifications. Click on the notification badge - the flyout bundle notification will show the correct number - 3
Expand the bundle - the three notifications will be displayed. 'Mark as read' one of them - click to close the bundle. The badge counter gets updated to 2 (correct). The bundle count still showing - 3.

~~3. Click to expand the bundle - all three notifications are still displayed.~~ -- Not happening anymore.

RESOLVED in separate tickets: Not quite severe as T135246: Wrong notification counts being shown due to cache pollution coming from non-SUL wikis the issue might add to some confusion though making the impression that 'Mark as read' does not work.

If users mark some messages in cross-wiki bundle as read and then collapse and expand the bundle (without of closing the flyout or navigating/refreshing), many incorrect states of count and displayed messages are presented to a user.

Screen Shot 2016-05-13 at 4.33.04 PM.png (271×599 px, 58 KB)

Screen Shot 2016-05-13 at 4.35.26 PM.png (256×544 px, 44 KB)

Screen Shot 2016-05-13 at 4.35.38 PM.png (413×527 px, 56 KB)

Screen Shot 2016-05-13 at 4.44.09 PM.png (411×556 px, 60 KB)

Related Objects

Mentioned In: T135246: Wrong notification counts being shown due to cache pollution coming from non-SUL wikis
T121930: Cross-wiki mark as read doesn't work
Mentioned Here: T121930: Cross-wiki mark as read doesn't work
T135246: Wrong notification counts being shown due to cache pollution coming from non-SUL wikis

Event Timeline

Etonkovidova created this task.May 13 2016, 11:53 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 13 2016, 11:53 PM

Etonkovidova mentioned this in T121930: Cross-wiki mark as read doesn't work.May 14 2016, 1:08 AM

Quiddity mentioned this in T135246: Wrong notification counts being shown due to cache pollution coming from non-SUL wikis.May 16 2016, 4:29 PM

I think several issues are being conflated here:

The "View 3 notifications" label doesn't update after marking things as read. That's something that we didn't have task for before, so that's what I think this task should be about.
Marking as read doesn't always work. I believe this is why one of the notifications came back. This is T121930.
Counts can get out of date in all sorts of ways. This is T135246.

• jmatazzoni edited projects, added Collaboration-Team-Triage; removed Collab-Team-2016-Apr-Jun-Q4.May 16 2016, 9:24 PM

• Mattflaschen-WMF added a project: Notifications.May 16 2016, 9:43 PM

Catrope renamed this task from [production] Expandable cross-wiki bundle notification count does not get updated after some messages were marked as read to Expandable cross-wiki bundle notification count does not get updated after some messages were marked as read.May 16 2016, 9:43 PM

With both - T135246 and T121930 being resolved by now, I re-checked the following and the issue still exists.

The "View 3 notifications" label doesn't update after marking things as read. That's something that we didn't have task for before, so that's what I think this task should be about.

I've updated the task description.

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 6 2018, 4:50 AM

Etonkovidova updated the task description. (Show Details)Sep 6 2018, 4:54 AM

JTannerWMF moved this task from Inbox to Needs Discussion on the Growth-Team board.Sep 6 2018, 9:05 AM

SBisson changed the subtype of this task from "Task" to "Bug Report".Oct 16 2018, 1:09 PM

SBisson changed the subtype of this task from "Bug Report" to "Task".Oct 16 2018, 6:41 PM

SBisson moved this task from Needs Discussion to FY 2019-20 on the Growth-Team board.Oct 22 2018, 10:40 AM

JTannerWMF moved this task from FY 2019-20 to Sprint 0 (Growth Team) on the Growth-Team board.Nov 7 2018, 8:31 PM

JTannerWMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

JTannerWMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 8 2018, 3:29 PM

This is too hard. I spent 2 hours trying to get the "View 3 notifications" label to update itself with the correct cross-wiki count, tried 2 different approaches, and they both don't work. I'm sure this can be done if we put more work into it, but I've already spent too much time on a minor cosmetic change. It's not worth it.

Also even if we did fix the number, we still wouldn't fix the list of wikis, or the correct plural conjugation in the message with the number of wikis.

	F4008075: Screen Shot 2016-05-13 at 4.44.09 PM.png
	May 13 2016, 11:53 PM

	F4008064: Screen Shot 2016-05-13 at 4.35.26 PM.png
	May 13 2016, 11:53 PM

	F4008058: Screen Shot 2016-05-13 at 4.33.04 PM.png
	May 13 2016, 11:53 PM

	F4008068: Screen Shot 2016-05-13 at 4.35.38 PM.png
	May 13 2016, 11:53 PM

Expandable cross-wiki bundle notification count does not get updated after some messages were marked as readClosed, DeclinedPublicActions

Description

Related Objects

Event Timeline

Expandable cross-wiki bundle notification count does not get updated after some messages were marked as read
Closed, DeclinedPublic
Actions