Fix "retrieve notification key" query

Before, we were sending the wrong parameters to the "retrieve notification key" endpoint. By submitting invalid arguments, we were causing every request to fail. We fixed the query for the "retrieve notification key" endpoint.
decision-labs · Jul 7, 2020 · b328a75 · b328a75
1 parent fcf66dc
commit b328a75
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/lib/fcm.rb b/lib/fcm.rb
@@ -89,11 +89,7 @@ def remove_registration_ids(key_name, project_id, notification_key, registration
   alias remove remove_registration_ids
 
   def recover_notification_key(key_name, project_id)
-    params = {
-      query: {
-        notification_key_name: key_name
-      }
-    }
+    params = {notification_key_name: key_name}
 
     extra_headers = {
       'project_id' => project_id

diff --git a/spec/fcm_spec.rb b/spec/fcm_spec.rb
@@ -472,6 +472,25 @@
     end # remove context
   end
 
+  describe "#recover_notification_key" do
+    it "sends a 'retrieve notification key' request" do
+      uri = "#{FCM::GROUP_NOTIFICATION_BASE_URI}/gcm/notification"
+      endpoint = stub_request(:get, uri).with(
+        headers: {
+          'Content-Type' => 'application/json',
+          'Authorization' => "key=TEST_SERVER_KEY",
+          'project_id' => "TEST_PROJECT_ID"
+        },
+        query: {notification_key_name: "TEST_KEY_NAME"}
+      )
+      client = FCM.new("TEST_SERVER_KEY")
+
+      client.recover_notification_key("TEST_KEY_NAME", "TEST_PROJECT_ID")
+
+      expect(endpoint).to have_been_requested
+    end
+  end
+
   describe 'subscribing to a topic' do
     # TODO
   end