[1.x] Async validate #69
Conversation
|
Hey @timacdonald , thanks for the hard work! |
|
It will cover all packages. Still a WIP. |
|
Hello, Is there any progress on this? It's been almost a month since this has been in Draft. It would be very helpful to have this feature implemented. I have an application in production that isn't working perfectly because I am waiting on this feature. Thank you. |
|
@djurovicigoor, still working on this, just had a few other things that were a higher priority. This one is back on my list and being pushed forward. |
packages/core/src/validator.ts
Outdated
| if (isAxiosError(error) && isCancel(error)) { | ||
| throw new RequestCancelled('An in-flight Precognition request was cancelled.', { cause: error }) | ||
| } |
There was a problem hiding this comment.
Could we resolve this and then never resolve the latestPromise instead of throwing an error?
There was a problem hiding this comment.
I'm wondering if this will fix #73 as well. This seems very much related.
| if (touched.length === 0) { | ||
| return | ||
| } |
There was a problem hiding this comment.
This is now handled in the before callback, which makes better sense to colocate things.
No description provided.