www.fgks.org   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long string in list description doesn't wrap #4974

Closed
RayBB opened this issue Apr 3, 2021 · 0 comments · Fixed by #5017
Closed

Long string in list description doesn't wrap #4974

RayBB opened this issue Apr 3, 2021 · 0 comments · Fixed by #5017
Labels
Lead: @bpmcneilly Issues overseen by Brian (Accessibility Lead) [managed] Type: Bug Something isn't working. [managed]

Comments

@RayBB
Copy link
Collaborator
RayBB commented Apr 3, 2021

Long strings are making the mobile view (and sometimes desktop) of lists expand beyond where they should.

Evidence / Screenshot (if possible)

Spoiler

image

image

image

image

Relevant url?

https://openlibrary.org/people/raybb/lists/OL195245L/Books_about_Open_Source
https://openlibrary.org/people/raybb/lists
https://openlibrary.org/works/OL8193508W/Alice's_Adventures_in_Wonderland/lists
It also happens on the "edit list" page in the preview of the description (see screenshot 4)

Steps to Reproduce

  1. Go to the pages on a mobile device
  • Actual: Long string caused the page to get wider
  • Expected: Long string wraps

Details

  • Logged in (Y/N)? y
  • Browser type/version? FF/Chrome
  • Operating system? Mac
  • Environment (prod/dev/local)? prod

Proposal & Constraints

We can add overflow-wrap: break-word; to the mybooks-list class, which is present on the first three pages.

We could also add it to the wmd-preview but that file has a note saying not to add new markdown there. I'm not sure where else it would be added.

Related files

https://github.com/internetarchive/openlibrary/blob/master/static/css/components/mybooks-list.less
https://github.com/internetarchive/openlibrary/blob/master/static/css/legacy-wmd.less

Stakeholders

@RayBB RayBB added Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Apr 3, 2021
@mekarpeles mekarpeles added Lead: @bpmcneilly Issues overseen by Brian (Accessibility Lead) [managed] and removed Needs: Lead labels Apr 12, 2021
@mekarpeles mekarpeles removed the Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] label Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @bpmcneilly Issues overseen by Brian (Accessibility Lead) [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants