www.fgks.org   »   [go: up one dir, main page]

r11073 pywikipedia - Code Review archive

Repository:pywikipedia
Revision:< r11072‎ | r11073 | r11074 >
Date:05:31, 14 February 2013
Author:amir
Status:ok (Comments)
Tags:
Comment:
English wikipedia became a client of wikidata
Modified paths:
  • /trunk/pywikipedia/families/wikipedia_family.py (modified) (history)

Diff [purge]

Index: trunk/pywikipedia/families/wikipedia_family.py
——@@ -1538,7 +1538,7 @@
15391539 return self.code2encoding(code),
15401540
15411541 def shared_data_repository(self, code, transcluded=False):
1542 - if not transcluded or code in ['he', 'hu', 'it']:
 1542+ if not transcluded or code in ['en', 'he', 'hu', 'it']:
15431543 return ('wikidata', 'wikidata')
15441544 else:
15451545 return (None, None)

Sign-offs

UserFlagDate
جوادtested10:12, 14 February 2013 (struck 10:17, 14 February 2013)

Follow-up revisions

RevisionCommit summaryAuthorDate
r11074wikidata is transcluded in en-wiki; update from tunk r11073xqt13:54, 14 February 2013

Comments

#Comment by Yurik (talk | contribs)   06:51, 14 February 2013

As I wrote in the email, ideally an API call should be used instead of a blacklist:

https://en.wikipedia.org/w/api.php?action=query&meta=wikibase

this way timely code updates are not as critical.

#Comment by Ladsgroup (talk | contribs)   10:17, 14 February 2013

When the wikis are a few i think it's the best that we use blacklist but I'll work on your propose when wikis became more.

#Comment by Xqt (talk | contribs)   14:14, 14 February 2013

As we see at rewrite branch it is not a bad idea to have sth like a cache for site informations. And a family file is a config cache, isn't it?

#Comment by Yurik (talk | contribs)   14:19, 14 February 2013

family file is a manually maintained cache - the worst possible kind :)

#Comment by Xqt (talk | contribs)   11:54, 25 February 2013

Not in every case. It is more flexible than a cache with fixed time intervall which could have old data, faster than getting information directly from the api but on the other hand more expensive to keep it up to date.

Status & tagging log