//pull_requests/show" data-pjax-transient="true"/>
www.fgks.org   »   [go: up one dir, main page]
Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39507: add HTTP status 418 "I'm a Teapot" #18291

Open
wants to merge 5 commits into
base: master
from
Open

bpo-39507: add HTTP status 418 "I'm a Teapot" #18291

wants to merge 5 commits into from
+6 −0

Conversation

@rrhodes
Copy link

rrhodes commented Jan 31, 2020 •
edited by bedevere-bot

What?

Adding HTTP status 418 "I'm a Teapot" to HTTPStatus in http library.

Why?

HTTP status code documented in RFC 2324: Hyper Text Coffee Pot Control Protocol (HTCPCP/1.0).

https://bugs.python.org/issue39507
rossrhodes
add HTTP status 418 I'm a Teapot
Loading status checks…
057f7e1
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
Copy link

the-knights-who-say-ni commented Jan 31, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@rrhodes

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@rrhodes

This comment has been minimized.

Sign in to view
Copy link
Author

rrhodes commented Jan 31, 2020 •
edited

Signed the CLA now. Following the given documentation and waiting at least one US business day for this to process.
@blurb-it
📜🤖 Added by blurb_it.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d8ba3a0
@corona10
corona10 suggested changes Jan 31, 2020
View changes
Copy link
Member

corona10 left a comment

https://github.com/python/cpython/blob/master/Doc/library/http.rst

The document should be updated :)
rrhodes added 2 commits Jan 31, 2020
@rrhodes
document HTTP 418 I'm a Teapot
b732a66
@rrhodes
Merge branch 'fix-issue-39507' of https://github.com/rrhodes/cpython …
Loading status checks…
043570a 
…into fix-issue-39507
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #18291 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18291      +/-   ##
==========================================
- Coverage   82.20%   82.12%   -0.08%     
==========================================
  Files        1957     1954       -3     
  Lines      589079   583368    -5711     
  Branches    44401    44401              
==========================================
- Hits       484247   479096    -5151     
+ Misses      95174    94630     -544     
+ Partials     9658     9642      -16
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-12.86%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Lib/dbm/__init__.py 66.66% <0.00%> (-4.45%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.87%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
... and 313 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a4054...043570a. Read the comment docs.
@rrhodes

This comment has been minimized.

Sign in to view
Copy link
Author

rrhodes commented Jan 31, 2020

Only outstanding action: waiting at least one business day for CLA records to update to include me.
@rrhodes

This comment has been minimized.

Sign in to view
Copy link
Author

rrhodes commented Jan 31, 2020

@corona10, I think I’ve completed all outstanding tasks: CLA signed and all checks have passed. Anything further you require from me?
@corona10
corona10 suggested changes Feb 1, 2020
View changes
Copy link
Member

corona10 left a comment

@rrhodes
rectify 'I'm a teapot' name and include unit test
Loading status checks…
61c9285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

Assignees
No one assigned
Labels
CLA signed awaiting core review
Projects
None yet
Milestone
No milestone
4 participants
@rrhodes @the-knights-who-say-ni @corona10 @bedevere-bot
You can’t perform that action at this time.